Remove deprecated code as marked by https://github.com/mglaman/drupal-check

> workbench_access: drupal-check -d ./
 71/71 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------- 
  Line   src/AccessControlHierarchyInterface.php                                               
 ------ -------------------------------------------------------------------------------------- 
  18     Interface Drupal\workbench_access\AccessControlHierarchyInterface extends deprecated  
         interface Drupal\Component\Plugin\ConfigurablePluginInterface.                        
 ------ -------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Functional\AccessByRoleFormTest)  
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                           
         class Drupal\Tests\workbench_access\Functional\AccessByRoleFormTest.                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Functional\AccessByUserFormTest)  
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                           
         class Drupal\Tests\workbench_access\Functional\AccessByUserFormTest.                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Functional\AssignUserFormTest)  
 ------ --------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                         
         class Drupal\Tests\workbench_access\Functional\AssignUserFormTest.                                                               
 ------ --------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Functional\NodeFormMenuTest)  
 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                       
         class Drupal\Tests\workbench_access\Functional\NodeFormMenuTest.                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Functional\NodeFormTest)  
 ------ --------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                   
         class Drupal\Tests\workbench_access\Functional\NodeFormTest.                                                               
 ------ --------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Functional\TaxonomySchemeUITest)  
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                           
         class Drupal\Tests\workbench_access\Functional\TaxonomySchemeUITest.                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\ConfigDependenciesTest)  
 ------ --------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                         
         class Drupal\Tests\workbench_access\Kernel\ConfigDependenciesTest.                                                               
 ------ --------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\EntityTestAccessTest)  
 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                       
         class Drupal\Tests\workbench_access\Kernel\EntityTestAccessTest.                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\FilterAccessTest)  
 ------ --------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                   
         class Drupal\Tests\workbench_access\Kernel\FilterAccessTest.                                                               
 ------ --------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\FlushTest)  
 ------ -------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                            
         class Drupal\Tests\workbench_access\Kernel\FlushTest.                                                               
 ------ -------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\InlineEntityFormTest)  
 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                       
         class Drupal\Tests\workbench_access\Kernel\InlineEntityFormTest.                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\NodeAccessTest)  
 ------ ------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                 
         class Drupal\Tests\workbench_access\Kernel\NodeAccessTest.                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\NodeMenuTest)  
 ------ ----------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                               
         class Drupal\Tests\workbench_access\Kernel\NodeMenuTest.                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\SectionCacheTest)  
 ------ --------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                   
         class Drupal\Tests\workbench_access\Kernel\SectionCacheTest.                                                               
 ------ --------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Traits/WorkbenchAccessTestTrait.php (in context of class Drupal\Tests\workbench_access\Kernel\TaxonomyAccessTest)  
 ------ ----------------------------------------------------------------------------------------------------------------------------- 
  18     Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in                                     
         class Drupal\Tests\workbench_access\Kernel\TaxonomyAccessTest.                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------- 
  Line   workbench_access.post_update.php                                                 
 ------ --------------------------------------------------------------------------------- 
  79     Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
  80     Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
  124    Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
  125    Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
 ------ --------------------------------------------------------------------------------- 

                                                                                                    
 [ERROR] Found 20 errors
CommentFileSizeAuthor
#4 3090181-workbench-access_deprecated.patch5.6 KBagentrickard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agentrickard created an issue. See original summary.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Plug... is not ready to be removed yet, if we support 8.6.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

Fixing that one bad Trait call leaves us with:

 ------ -------------------------------------------------------------------------------------- 
  Line   src/AccessControlHierarchyInterface.php                                               
 ------ -------------------------------------------------------------------------------------- 
  18     Interface Drupal\workbench_access\AccessControlHierarchyInterface extends deprecated  
         interface Drupal\Component\Plugin\ConfigurablePluginInterface.                        
 ------ -------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------- 
  Line   workbench_access.post_update.php                                                 
 ------ --------------------------------------------------------------------------------- 
  79     Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
  80     Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
  124    Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
  125    Fetching deprecated class constant WORKBENCH_ACCESS_ROLES_STATE_PREFIX of class  
         Drupal\workbench_access\RoleSectionStorageInterface.                             
 ------ ---------------------------------------------------------------------------------
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Active » Needs review
FileSize
3090181-workbench-access_deprecated.patch5.6 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Looks good to me 🎉

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

Odd, that I am getting test fails on Travis.

Should we be testing other versions here on d.o.?

https://github.com/agentrickard/workbench_access/pull/131/checks?check_r...

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Can you reproduce it locally?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Issue tags: +DrupalSouth 2019
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

No, I cannot. PHP 7.2 and Drupal 8.7-dev.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Reviewed & tested by the community » Fixed

Committed. There are some more complex changes that need to be handled now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.