I noticed that the breadcrumb.component.scss , the value of font-size not valid.

CommentFileSizeAuthor
#7 3090319-7.patch1.78 KBRajab Natshah
#4 3090319-4.patch433 bytesQusai Taha
#2 3090319-1.patch432 bytesQusai Taha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

qusai taha created an issue. See original summary.

Qusai Taha’s picture

Qusai Taha CreditAttribution: Qusai Taha at Vardot commented
FileSize
3090319-1.patch432 bytes
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Status: Needs review » Needs work

Thank you Qusai for reporting and patching
Nice catch!
We could switch it to use RFS

 .breadcrumb {
   @include font-size($font-size-sm);
 }

I do think we maybe need to switch all font-size: to use the @include font-size() mixin, we could do that in a stand a lone issue.
Please, upload a new patch

Qusai Taha’s picture

Qusai Taha CreditAttribution: Qusai Taha at Vardot commented
FileSize
3090319-4.patch433 bytes
Qusai Taha’s picture

Qusai Taha CreditAttribution: Qusai Taha at Vardot commented

Tank you rajab.
I did it.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Assigned: Qusai Taha » Unassigned
Status: Needs work » Needs review
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
FileSize
3090319-7.patch1.78 KB

The right patch would be as the attached patch

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Assigned: Unassigned » Mohammed J. Razem
Issue tags: +varbase-8.7.3

Committed ... Thank you :)

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.