Drupal 9 Readiness [#3090752]

Problem/Motivation

Be ready for Drupal 9.

Proposed resolution

[ ] Create a patch which follow the Gabor documentation: http://hojtsy.hu/blog/2018-dec-17/how-automate-testing-whether-your-drup... to expose potential code flaws
[ ] Test the module using umami and the Upgrade Status module

Remaining tasks

[ ] Create a patch which follow the Gabor documentation: http://hojtsy.hu/blog/2018-dec-17/how-automate-testing-whether-your-drup... to expose potential code flaws
[ ] Test the module using umami and the Upgrade Status module

Comment	File	Size	Author
#6	3090752-06.patch	14.87 KB	wengerk
#6	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.9 27 pass PHP 7.3 & MySQL 5.7, D9.0 27 pass
#5	3090752-05.patch	3.46 KB	wengerk
#5	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.8 27 pass PHP 7.2 & MySQL 5.7, D9.0 Composer require failure PHP 7.3 & MySQL 5.7, D8.9 Build Successful PHP 7.3 & MySQL 5.7, D9.0 Composer require failure
#4	3090752-04.patch	2.11 KB	wengerk
#4	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7 13 pass, 3 fail PHP 7.2 & MySQL 5.7, D9.0 Composer require failure
#3	commerce_trustedshops-3090752-2.patch	1.04 KB	Tolyan4ik
#3	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7 21 pass PHP 7.2 & MySQL 5.7, D9.0 Composer require failure

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 October 2019 at 10:45

wengerk created an issue. See original summary.

Comment #2

Tolyan4ik CreditAttribution: Tolyan4ik at EPAM Systems commented 5 November 2019 at 10:07

25/25 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------------------------------------
Line commerce_trustedshops.install
------ ----------------------------------------------------------------------
14 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
21 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

[ERROR] Found 2 errors

Comment #3

Tolyan4ik CreditAttribution: Tolyan4ik at EPAM Systems commented 5 November 2019 at 10:08

Status:

Active

» Needs review

File	Size
commerce_trustedshops-3090752-2.patch	1.04 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7 21 pass PHP 7.2 & MySQL 5.7, D9.0 Composer require failure

Please check

Comment #4

wengerk

he/him

French

Lausanne

CreditAttribution: wengerk at Antistatique commented 15 November 2019 at 12:13

File	Size
3090752-04.patch	2.11 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7 13 pass, 3 fail PHP 7.2 & MySQL 5.7, D9.0 Composer require failure

Here a patch with the proper drupal 9 key and necessary drupalci.yml to detect code flaws

Comment #5

wengerk

he/him

French

Lausanne

CreditAttribution: wengerk at Antistatique commented 15 November 2019 at 12:22

File	Size
3090752-05.patch	3.46 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.8 27 pass PHP 7.2 & MySQL 5.7, D9.0 Composer require failure PHP 7.3 & MySQL 5.7, D8.9 Build Successful PHP 7.3 & MySQL 5.7, D9.0 Composer require failure

Here a patch to fix the defaultTheme Drupal 9 requirement for Functional Testing.

Comment #6

wengerk

he/him

French

Lausanne

CreditAttribution: wengerk at Antistatique commented 5 July 2020 at 11:50

File	Size
3090752-06.patch	14.87 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.9 27 pass PHP 7.3 & MySQL 5.7, D9.0 27 pass

New versions that should works with 8.8.8+ & Commerce 2.20

Comment #7

wengerk

he/him

French

Lausanne

CreditAttribution: wengerk at Antistatique commented 5 July 2020 at 11:50

2 files were hidden/shown/deleted

File	Size
commerce_trustedshops-3090752-2.patch	1.04 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7 21 pass PHP 7.2 & MySQL 5.7, D9.0 Composer require failure
3090752-04.patch	2.11 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7 13 pass, 3 fail PHP 7.2 & MySQL 5.7, D9.0 Composer require failure