Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Be ready for Drupal 9.
Proposed resolution
- [ ] Create a patch which follow the Gabor documentation: http://hojtsy.hu/blog/2018-dec-17/how-automate-testing-whether-your-drup... to expose potential code flaws
- [ ] Test the module using umami and the Upgrade Status module
- [ ] Add
drupal-check
as a dev-dependency, update theDEVELOPPING.md
file (section [## 🚔 Check Drupal coding (...) practices) with the newdrupal-check
feature, update the scripts/hooks/post-commit file with thedrupal-check
command
Remaining tasks
- [ ] Create a patch which follow the Gabor documentation: http://hojtsy.hu/blog/2018-dec-17/how-automate-testing-whether-your-drup... to expose potential code flaws
- [ ] Test the module using umami and the Upgrade Status module
- [ ] Run & past result of
drupal-check
- [ ] Add
drupal-check
in theDEVELOPPING.md
process
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff-3090756-11-12.txt | 3.55 KB | wengerk |
#12 | 3090756-12.patch | 12.98 KB | wengerk |
#11 | 3090756-11.patch | 9.31 KB | wengerk |
#11 | interdiff-3090756-10-11.txt | 709 bytes | wengerk |
#10 | 3090756-10.patch | 8.44 KB | wengerk |
Comments
Comment #2
wengerkLet's test the patch
Comment #3
wengerkComment #4
wengerkLet's try this patch, made many changes so it may break tests ...
This patch will force Template Whisperer to be used on Drupal 8.9+ so we will not be able to merge it soon, maybe a 9.x branch should be created.
Comment #5
wengerk... some changes about pagers and TemplateWhispererSuggestionListBuilder
Comment #6
wengerkadding the
core_version_requirement
key for Drupal 9Comment #7
wengerkremove the core key as required when using core_version_requirement for ^8.8
Comment #8
anu.a_95 CreditAttribution: anu.a_95 at Zyxware Technologies commentedPatch applied successfully. The patch fixes the below 2 errors which were thrown up without the patch
88 Call to deprecated function pager_default_initialize():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Pager\PagerManagerInterface->defaultInitialize() instead.
108 Call to deprecated method url() of class
Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Please use toUrl() instead.
8 other errors like some test case missing was thrown up with and without patch.
Comment #9
C-Logemann"ContributionWeekend2020“ is the "official" tag suggested on global event page.
Comment #10
wengerkHere a patch to fix the defaultTheme Drupal 9 requirement for Functional Testing.
Comment #11
wengerkUse
stark
them instead ofclass
on functional UI tests to uselinks.action
.Comment #12
wengerklast version with explanation of versions in README.md.
Comment #14
wengerk