Attached is a small patch that :
* Uses this->t instead of t() for two leftover occurences.
* Removes "The" and the full stop from form labels
* Changes the unclear documentation of ProxySubscriber::checkFileOrigin

CommentFileSizeAuthor
stage_file_proxy-minor-changes.patch4.39 KBinterX
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

interX created an issue. See original summary.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented
Status: Needs review » Reviewed & tested by the community

These look good to me. Thanks! Will wait a bit for feedback, but I plan to commit this.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented
Title: Form coding standards » Form coding standards - including translation string changes

  • greggles committed 15114ef on 8.x-1.x authored by interX 
    Issue #3091102 by interX: Form coding standards - including translation...
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented
Status: Reviewed & tested by the community » Fixed

This is now committed - thanks for your help!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.