Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In the access callback we return either "FALSE", or webform_node_update_access($node). But if another module adds a custom access callback too, and this is executed before this callback, the results of that callback are ignored. We should include these results too.
Comment | File | Size | Author |
---|---|---|---|
#4 | access_callback-3091347-4.patch | 1.69 KB | JoshaHubbers |
Comments
Comment #2
JoshaHubbers CreditAttribution: JoshaHubbers at iO commentedThis patch returns FALSE, or the original callback combined with webform_node_update_access.
Comment #3
TVoesenek CreditAttribution: TVoesenek at iO commentedThe $retval variable is never used, looks like this line is some debug code, so it should be removed.
For the rest, the patch looks good.
Comment #4
JoshaHubbers CreditAttribution: JoshaHubbers at iO commentedGood catch! Corrected patch.
Comment #5
JoshaHubbers CreditAttribution: JoshaHubbers at iO commentedComment #6
TVoesenek CreditAttribution: TVoesenek at iO commentedLooks good now ;-)
Comment #8
paulvandenburg CreditAttribution: paulvandenburg at iO commentedChanged the short array syntax to the long one since that is officially not yet supported for d7, and we've not yet officially dropped support for older php versions.
But essentially applied #4.