Support from Acquia helps fund testing for Drupal Acquia logo

Comments

prudloff created an issue. See original summary.

rachel_norfolk’s picture

Issue tags: -DrupalCon Amsterdam 2019 +Amsterdam2019

retagging

prudloff’s picture

Status: Active » Needs review
GaëlG’s picture

Status: Needs review » Needs work
Issue tags: +Drupal 9 compatibility

Now it does ;)

------ ------------------------------------------------------------------------------------------
Line src/Tests/RiddlerTestCase.php
------ ------------------------------------------------------------------------------------------
Class Drupal\captcha\Tests\CaptchaBaseWebTestCase not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
16 Class Drupal\captcha\Tests\CaptchaBaseWebTestCase not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ ------------------------------------------------------------------------------------------

[ERROR] Found 2 errors

sushyl’s picture

Assigned: Unassigned » sushyl
Issue tags: +DIACWAug2020
Sahana _N’s picture

Status: Needs work » Needs review
FileSize
356 bytes

Please review the patch.

sushyl’s picture

Assigned: sushyl » Unassigned
GaëlG’s picture

Status: Needs review » Needs work
FileSize
352 bytes

This little patch is for 1.1, for composer needs (because of #3036459: Packaging info from .info.yml often creates conflicts when patching).

BTW, #6 is the same as #0, it does not solve #4.

Pooja Ganjage’s picture

Hi,

Creating a patch for this issue and solved as mentioned in #4 comment.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Status: Needs work » Needs review
Pooja Ganjage’s picture

Pooja Ganjage’s picture

Pooja Ganjage’s picture

Anybody’s picture

Status: Needs review » Needs work

Thank you for your contributions. The patches don't fulfil Drupal coding standards. For example #13 adds lots of commented out code. Was that generated by a tool?

We need qualified and tested patches here please, thank you.

Pooja Ganjage’s picture

Anybody’s picture

Hi and thanks a lot!

See test result:

PHP Fatal error: Class 'Drupal\captcha\Tests\CaptchaBaseWebTestCase' not found in /var/www/html/modules/contrib/riddler/src/Tests/RiddlerTestCase.php on line 16

mirom’s picture

It seems that the original test is still there, hence the failures. In attached patch, I'm removing it and fixing coding standard error.

mirom’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 17: 3091480-17.patch, failed testing. View results

mirom’s picture

Status: Needs work » Needs review
FileSize
12.23 KB

Adding set up function to create admin user.

Status: Needs review » Needs work

The last submitted patch, 20: 3091480-19.patch, failed testing. View results

mirom’s picture

Seems hat we either need to test without JS or rewrite the test to JavascriptTestBase. Source - https://www.drupal.org/project/drupal/issues/2797957#comment-11777881

GaëlG’s picture

mirom’s picture

Status: Needs work » Needs review
mirom’s picture

@Anybody - when can we expect this committed and d9 compatible release?

ressa’s picture

Status: Needs review » Reviewed & tested by the community

Great work everybody, thanks! I applied the patch to latest dev-version of the module in Drupal 9.2, and successfully created the question "What's your favorite color baby?" which only accepted "Living Colour" (or non-capitalized, since "Case insensitive validation: lowercase/uppercase errors are ignored" was enabled), which was the correct answer.

So as far as functionality goes, the module works very well in Drupal 9.

alex_optim made their first commit to this issue’s fork.

  • alex_optim committed 50721e9 on 8.x-1.x authored by mirom
    Issue #3091480 by Pooja Ganjage, mirom, GaëlG, prudloff, Sahana _N:...
alex_optim’s picture

Status: Reviewed & tested by the community » Fixed

Thanks. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.