Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The module does not seem to use any deprecated code so the attached patch adds metadata that tells user the module can be used on Drupal 9.
Comment | File | Size | Author |
---|---|---|---|
#20 | 3091480-19.patch | 12.23 KB | mirom |
| |||
#17 | 3091480-17.patch | 11.85 KB | mirom |
| |||
#15 | 3091480-15.patch | 3.57 KB | Pooja Ganjage |
#13 | 3091480-13.patch | 8.69 KB | Pooja Ganjage |
#12 | 3091480-12.patch | 8.72 KB | Pooja Ganjage |
Issue fork riddler-3091480
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rachel_norfolkretagging
Comment #3
prudloff CreditAttribution: prudloff at Insite commentedComment #4
GaëlGNow it does ;)
Comment #5
sushylComment #6
Sahana _N CreditAttribution: Sahana _N at Specbee commentedPlease review the patch.
Comment #7
sushylComment #8
GaëlGThis little patch is for 1.1, for composer needs (because of #3036459: Packaging info from .info.yml often creates conflicts when patching).
BTW, #6 is the same as #0, it does not solve #4.
Comment #9
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
Creating a patch for this issue and solved as mentioned in #4 comment.
Please review the patch.
Thanks.
Comment #10
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #11
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #12
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #13
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #14
AnybodyThank you for your contributions. The patches don't fulfil Drupal coding standards. For example #13 adds lots of commented out code. Was that generated by a tool?
We need qualified and tested patches here please, thank you.
Comment #15
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #16
AnybodyHi and thanks a lot!
See test result:
Comment #17
mirom CreditAttribution: mirom at Slovak Drupal Association commentedIt seems that the original test is still there, hence the failures. In attached patch, I'm removing it and fixing coding standard error.
Comment #18
mirom CreditAttribution: mirom at Slovak Drupal Association commentedComment #20
mirom CreditAttribution: mirom at Slovak Drupal Association commentedAdding set up function to create admin user.
Comment #22
mirom CreditAttribution: mirom at Slovak Drupal Association commentedSeems hat we either need to test without JS or rewrite the test to JavascriptTestBase. Source - https://www.drupal.org/project/drupal/issues/2797957#comment-11777881
Comment #23
GaëlGComment #25
mirom CreditAttribution: mirom at Slovak Drupal Association commentedComment #26
mirom CreditAttribution: mirom at Slovak Drupal Association, Czech Drupal Association commented@Anybody - when can we expect this committed and d9 compatible release?
Comment #27
ressa CreditAttribution: ressa at Ardea commentedGreat work everybody, thanks! I applied the patch to latest dev-version of the module in Drupal 9.2, and successfully created the question "What's your favorite color baby?" which only accepted "Living Colour" (or non-capitalized, since "Case insensitive validation: lowercase/uppercase errors are ignored" was enabled), which was the correct answer.
So as far as functionality goes, the module works very well in Drupal 9.
Comment #30
alex_optimThanks. Committed.