Support from Acquia helps fund testing for Drupal Acquia logo

Comments

szeidler created an issue. See original summary.

szeidler’s picture

FileSize
662 bytes

Adding drupalci.yml to check for deprecations.

Kristen Pol’s picture

Issue tags: +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

komalk’s picture

Status: Active » Needs review
szeidler’s picture

Status: Needs review » Needs work

Thank you for your contribution.

I just ran a test. Unfortunately bumping up the core compatibility is not enough. The automated tests are failing and need to be slightly adjusted.

salah1’s picture

Assigned: Unassigned » salah1

Working on this.

salah1’s picture

Fixed the test error (some of tests now require $defaultTheme be set).
Didn't include the interdiff because patch #4 only had (core_version_requirement: ^8 || ^9) so rest of changes are from this patch.

szeidler’s picture

Hi @salah1,

was there any reason, that you removed the trait? This is breaking the test.

salah1’s picture

Status: Needs work » Needs review
FileSize
2.02 KB

Hi @szeidler, i was getting error locally when i run the test and removed it then forgot to put it back.
I now put that back and hopefully we will see green tests.
Thanks for catching it.

salah1’s picture

Forgot to add [protected $defaultTheme = 'stark';] to the /test/Functional + fix few coding standard errors.

szeidler’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for your contribution. This looks good now and everything went green.

  • szeidler committed d61f0ce on 8.x-1.x authored by salah1
    Issue #3091727 by salah1, szeidler, komalkolekar: Drupal 9 Readiness
    
szeidler’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.