Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Add Drupal 9 deprecation checks for the module to be able to test it regular before Drupal 9 release date.
Comment | File | Size | Author |
---|---|---|---|
#11 | 3091727-11.patch | 3.33 KB | salah1 |
#11 | interdiff-10-11.txt | 1.31 KB | salah1 |
#10 | 3091727-10.patch | 2.02 KB | salah1 |
#8 | 3091727-8.patch | 1.88 KB | salah1 |
#4 | 3091727-4.patch | 369 bytes | komalk |
Comments
Comment #2
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedAdding drupalci.yml to check for deprecations.
Comment #3
Kristen PolPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.
Comment #4
komalk CreditAttribution: komalk at Srijan | A Material+ Company for Drupal India Association commentedComment #5
komalk CreditAttribution: komalk at Srijan | A Material+ Company for Drupal India Association commentedComment #6
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedThank you for your contribution.
I just ran a test. Unfortunately bumping up the core compatibility is not enough. The automated tests are failing and need to be slightly adjusted.
Comment #7
salah1Working on this.
Comment #8
salah1Fixed the test error (some of tests now require $defaultTheme be set).
Didn't include the interdiff because patch #4 only had (core_version_requirement: ^8 || ^9) so rest of changes are from this patch.
Comment #9
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedHi @salah1,
was there any reason, that you removed the trait? This is breaking the test.
Comment #10
salah1Hi @szeidler, i was getting error locally when i run the test and removed it then forgot to put it back.
I now put that back and hopefully we will see green tests.
Thanks for catching it.
Comment #11
salah1Forgot to add [protected $defaultTheme = 'stark';] to the /test/Functional + fix few coding standard errors.
Comment #12
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedThanks for your contribution. This looks good now and everything went green.
Comment #14
szeidler CreditAttribution: szeidler at Ramsalt Lab commented