CommentFileSizeAuthor
#5 3092458-5.drupal.Remove-editormodule-BC-layers.patch7.74 KBlongwave
#2 3092458-2.patch8.87 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
3092458-2.patch8.87 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3092458-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Needs review

The test failures are in AggregatorDisplayConfigurableTest and TermDisplayConfigurableTest, this is broken in HEAD. Just as I determined the root cause, it got fixed: #2993642-73: Mechanism to disable preprocessing of base fields in taxonomy and aggregator entity types so they can be configured via the field UI. Re-testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
FileSize
3092458-5.drupal.Remove-editormodule-BC-layers.patch7.74 KB

Rerolled after the deprecated entity manager was already removed in #3087546: Remove deprecated entity manager

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Great, thank you!

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Verified there are no mentions of deprecated in the editor module after applying #5.

  • catch committed 6251b3e on 9.0.x 
    Issue #3092458 by Wim Leers, longwave, kim.pepper: Remove editor.module...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed 6251b3e and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.