Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Run a Deprecated Code Report for the Rain distro's custom code.
Comment | File | Size | Author |
---|---|---|---|
#11 | rain-D9-3092793-11.patch | 815 bytes | oknate |
#10 | rain-n3092793-10.patch | 1.67 KB | DamienMcKenna |
Comments
Comment #2
DamienMcKennaComment #3
anthonyf CreditAttribution: anthonyf at Mediacurrent commentedI'll run the report and post the results here.
Comment #4
anthonyf CreditAttribution: anthonyf at Mediacurrent commentedI ran the drupal-check tool with -d for deprecations on the Rain distro custom modules and it found one error in web/modules/contrib/rain_gatsby
Comment #5
anthonyf CreditAttribution: anthonyf at Mediacurrent commentedComment #6
drupalninja99 CreditAttribution: drupalninja99 at Mediacurrent commentedPR: https://bitbucket.org/mediacurrent/rain_gatsby/pull-requests/3
This updates rain_gatsby (which is a separate project.
We don't do much custom code in Rain projects so it's not surprising that not much was found. To the extent we have custom logic at all it's usually within the install files.
I did look up file_save_data and drupal_get_path which are two procedural functions we use fairly often and I don't see any documentation showing those aren't part of D9 for now.
The last thing I would like checked is the rain_theme projects which has some custom logic. At first glance I don't see anything that would look like it's deprecated.
Comment #7
drupalninja99 CreditAttribution: drupalninja99 at Mediacurrent commentedFinding some more things, looks like just FILE_EXISTS_REPLACE needs fixing
Comment #8
drupalninja99 CreditAttribution: drupalninja99 at Mediacurrent commentedRain_admin had no issues but this is what I found for rain_theme:
This might be a false positive?
Comment #9
DamienMcKennaThe BasicTwigExtensions problem isn't a false positive, it's a bug in how that file is loaded and it might be preventing the rest of the codebase from being analyzed.
Comment #10
DamienMcKennaThis updates the info files and fixes the deprecated constant.
Comment #11
oknateHere's a patch for the develop branch.
Comment #12
joestewart CreditAttribution: joestewart at Mediacurrent commentedBranch for testing with #11patch and composer dependency changes applied.
https://bitbucket.org/mediacurrent/rain/pull-requests/34/feature-3092793...
`composer require mediacurrent/rain:dev-feature/3092793--drupal-9`
Comment #13
oknateFYI, here are some recommended patches for using rain distro on Drupal 9:
Comment #14
drupalninja99 CreditAttribution: drupalninja99 at Mediacurrent commentedI haven't included any of @oknate's patch updates yet but I made sure to merge in all D9 compat PRs and re-tag with stable releases. Joe is going to work on the updated Drupal composer project. The big blocker for that is going to be Guardr but we can try to get that going next.
Comment #15
drupalninja99 CreditAttribution: drupalninja99 at Mediacurrent commentedI created https://www.drupal.org/project/guardr_core/issues/3174970#comment-13848425 to apply changes from @okanate to the Guardr "9.x-test" branch. This should allow Joe to test everything together in https://bitbucket.org/mediacurrent/drupal-project/src/.
Comment #16
drupalninja99 CreditAttribution: drupalninja99 at Mediacurrent commentedThese updates have all been merged