screenshot-20191111a.png
screenshot-20191111b.png
screenshot-20191111c.png
screenshot-20191111d.png
screenshot-20191111e.png
screenshot-20191111f.png
screenshot-20191111g.png
screenshot-20191111h.png
screenshot-20191111i.png

CommentFileSizeAuthor
#6 screenshot-20191111i.png868.59 KByas
#6 screenshot-20191111h.png770.53 KByas
#6 screenshot-20191111g.png865.27 KByas
#6 screenshot-20191111f.png840.38 KByas
#6 screenshot-20191111e.png801.82 KByas
#6 screenshot-20191111d.png866.99 KByas
#6 screenshot-20191111c.png819.58 KByas
#6 screenshot-20191111b.png896.69 KByas
#6 screenshot-20191111a.png988.19 KByas
#3 3093109-3.patch86.15 KBXiaohua Guan
#2 3093109-2.patch86.08 KBXiaohua Guan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3093109-2.patch86.08 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3093109-3.patch86.15 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@yas

Please review the patch file. Thanks.

BTW, I also did some refactoring.

  • Remove forms such as K8sNetworkPolicy*Form.php, which are not used.
  • Add suffix "Model" to the name of classes under Drupal\k8s\Service\K8sClientExtension\Models\ in order to make a difference between Models\K8sRole and Entity\K8sRole.
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
screenshot-20191111a.png988.19 KB
screenshot-20191111b.png896.69 KB
screenshot-20191111c.png819.58 KB
screenshot-20191111d.png866.99 KB
screenshot-20191111e.png801.82 KB
screenshot-20191111f.png840.38 KB
screenshot-20191111g.png865.27 KB
screenshot-20191111h.png770.53 KB
screenshot-20191111i.png868.59 KB

@xiaohua-guan

Thank you for adding the feature. I tested it and looks good to me. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

  • yas committed c244e79 on 8.x-2.x authored by Xiaohua Guan 
    Issue #3093109 by Xiaohua Guan, yas: Manage K8s Roles
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Again, thank you for fixing:

  • Remove forms such as K8sNetworkPolicy*Form.php, which are not used.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.