CommentFileSizeAuthor
#2 3093217.patch4.81 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
3093217.patch4.81 KB

This should do it.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

This looks great, I can confirm no deprecated code remains after applying this.

Just one nitpick…

+++ b/core/modules/workflows/workflows.services.yml
@@ -5,10 +5,6 @@ services:
-    class: \Drupal\workflows\WorkflowStateTransitionOperationsAccessCheck
+    class: Drupal\workflows\WorkflowStateTransitionOperationsAccessCheck

Out of scope change 🤓 But seems acceptable to just do this at the same time, so not marking Needs work.

  • catch committed 66ad65a on 9.0.x 
    Issue #3093217 by amateescu, Wim Leers: Remove workflows.module BC...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 66ad65a and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.