Refactor to use t() to $this->t()

CommentFileSizeAuthor
#12 3093828-10.patch374.96 KBjigish.addweb
#11 screenshot-2019-11-20a.png1.11 MByas
#8 3093828-8.patch374.97 KBjigish.addweb
#7 3093828-7.patch295.42 KBjigish.addweb
#6 3093828-6.patch374.51 KBjigish.addweb
#5 3093828-5.patch294.97 KBjigish.addweb
#3 3093828-3.patch350.33 KBjigish.addweb
#2 3093828-2.patch253.18 KBjigish.addweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-2.patch253.18 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-3.patch350.33 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Active » Needs review
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-5.patch294.97 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-6.patch374.51 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-7.patch295.42 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-8.patch374.97 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-9.patch374.97 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3095569: Composer could not parse version constraint / could not load package (2)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
screenshot-2019-11-20a.png1.11 MB

@jigish.addweb

I tested the patch for 8.x-2.x. Could you please fix the following errors?

screenshot-2019-11-20a.png

jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3093828-10.patch374.96 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@jigish.addweb

Thank you for the refactoring. Now it looks good to me, so I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 4ebe540 on 8.x-1.x authored by jigish.addweb 
    Issue #3093828 by jigish.addweb, yas: Refactor t() function to $this->t...

  • yas committed 8c3a55b on 8.x-2.x authored by jigish.addweb 
    Issue #3093828 by jigish.addweb, yas: Refactor t() function to $this->t...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.