Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Add core_version_requirement: ^8 || ^9 to admin_toolbar.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#18 | admin_toolbar-compatibility_with_D9-3094517-17.patch | 3.19 KB | adriancid |
|
Comments
Comment #2
robertoperuzzoComment #3
robertoperuzzoComment #4
MrPaulDriver CreditAttribution: MrPaulDriver commentedTested okay with php 7.2 and 7.3
Tested with Drupal Check
Comment #5
adriancidWe will commit this patch when D8.8 will be released.
Comment #6
adriancidComment #7
adriancidComment #8
oknateComment #9
oknateComment #10
romainj CreditAttribution: romainj as a volunteer commentedWhen applying the patch #8 I can no longer install the Admin Toolbar Tools module.
Comment #11
adriancid@romainj the patch #8 will only works for Drupal >= 8.8
Comment #12
oknateComment #13
oknateIt looks like we should update our tests to start testing against Drupal 8.8 before this is committed.
We should let people know, if they want to run less than Drupal 8.8, they'll need to restore the 'core: 8.x' part of the info file.
Comment #14
mmjvb CreditAttribution: mmjvb as a volunteer commentedSuggest to revert #8 just because it restricts usage of the new release to Drupal versions supporting core_version_requirement. My understanding is that was introduced in 8.7.8, with plans to backport.
Why would you want to restrict the new release to those versions of Drupal ?
Apart from the fact it changes the scope of the issue which should be reflected in the summary!
Comment #15
BerdirYes, not sure why this mixes ^8 and ^8.8, since before it required 8.6 and nothing else was changed it seems like it should be fine to consistently use ^8.7.7 || ^9 now in all .info.yml and composer.json files (not sure if nested composer.json files even work but it's there now, so should go with it).
Comment #16
BerdirComment #17
BerdirComment #18
adriancidComment #19
BerdirLooks fine to me, not sure why you don't use the identical string in composer.json and info.yml (^9 vs 9.0 and spaces) but this should work fine ;)
Comment #21
adriancidThanks @Berdir, I just copy and paste from somewhere with this format, I will put before commit the same format in both place.
Comment #22
mondrakeHi there, any plan for a point release with this included? Currently 2.0 does not install under D9 dev.
Comment #23
adriancid@mondrake no fot the moment, you can use the dev version.
Comment #24
mondrakeAlright, thanks!
Comment #26
Kristen PolThere was a discussion about adding the zero at the end of the versions in the #d9readiness Slack channel during Drupal 9 porting weekend and the consensus was that it's best practice to leave off the unnecessary zero, e.g.
Instead of:
you are encouraged to use:
Similar to the change record examples:
https://www.drupal.org/node/3070687
I've reviewed about 50 projects so far and almost all didn't include the extra zero.