Make the end date in a Date range field (DateRangeItem) optional.

Project link

https://www.drupal.org/project/optional_end_date

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/optional_end_date.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-optional_end_d...

Comments

Birk created an issue. See original summary.

vuil’s picture

Status: Needs review » Needs work

Thank you for the contribution!

Please unset &$table right after foreach because you will receive side-effects without that (optional_end_date.install).

__DIR__ should be used instead dirname(__FILE__) in optional_end_date.module file.

Birk’s picture

Status: Needs work » Needs review

Thank you for the review, I've updated the repository.

Commit: 90b0ec77

AkashKumar07’s picture

Status: Needs review » Reviewed & tested by the community

Applied changes looks good to me. Moving to RTBC.
Thanks

apaderno’s picture

Birk’s picture

I'm not sure what the "PAReview: single application approval" tag means, and if I need to do anything to proceed?

apaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update the project to opt it into security coverage.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

apaderno’s picture

Assigned: Unassigned » apaderno

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.