Problem/Motivation
We should add defaultTheme where it will be required in tests extending BrowserTestBase.
Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/2352949, which includes recommendations on which theme to use.
See https://www.drupal.org/node/3083055
and https://www.drupal.org/project/drupal/issues/3082655
Proposed resolution
Add the defaultTheme property to tests that extend BrowserTestBase, where appropriate or another theme where appropriate, based on https://www.drupal.org/node/3083055
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#7 | 3095617-7.patch | 444 bytes | AkashKumar07 |
| |||
#5 | add_defaultTheme_in_tests_extending_browserTestBase-3095617-4.patch | 853 bytes | Gnanagowthaman sankar |
| |||
#5 | interdiff_2-4.txt | 394 bytes | Gnanagowthaman sankar |
#2 | 3095617-2.patch | 880 bytes | rpayanm |
|
Comments
Comment #2
rpayanmComment #3
Berdirkernel tests don't need this.
Comment #4
Gnanagowthaman sankar CreditAttribution: Gnanagowthaman sankar as a volunteer and at UniMity Solutions Pvt Limited commentedHi @Berdir,
As you mentioned I made the following changes. Please review and let me know for any changes.
Thanks & Regards,
Gnanagowthaman sankar
Comment #5
Gnanagowthaman sankar CreditAttribution: Gnanagowthaman sankar as a volunteer and at UniMity Solutions Pvt Limited commentedPatch,
Thanks & Regards,
Gnanagowthaman sankar
Comment #6
BerdirThere's still a left-over spaces change now in the kernel test.
Comment #7
AkashKumar07 CreditAttribution: AkashKumar07 at OpenSense Labs commentedComment #8
BerdirThanks.
Comment #10
phenaproximaCommitted and pushed to 8.x-2.x. Thanks!