| mherchel |
@Jen Witkowski has some updated designs for the drop menu button at #3094769: Design for submenu button in main menu (at desktop widths) |
| mherchel |
We’re waiting on additional work on the messages block styling #3092337: Create messages block within proof of concept |
| vulcanr |
The submenu button looks great |
| vulcanr |
I guess a final review/approve from Andrew would seal the deal? (edited) |
| mherchel |
And that’s pretty much it. It’s been a quiet week |
| vulcanr |
in regards of the look&feel of it |
| vulcanr |
yeah, too much black friday offers to catch up |
| mherchel |
lol |
| vulcanr |
the block messages issues is just changes on the MR right ? |
| mherchel |
yep |
| vulcanr |
no designs (visual changes) ? |
| vulcanr |
I guess we might wait for MaddieP to wrap it up (edited) |
| vulcanr |
I was just thinking the other day about Status and Issues and Updates, and I'm still wondering: How do other projects do in regards of Code Review (when the project is not on D.org yet) |
| vulcanr |
Usually when they are on d.org is "quicker" since anyone can test the patch/fix/feature and move on tagging it as RTBM or something similar |
| mherchel |
yeah , i’ve been trying to update it in both places |
| mherchel |
It definitely increases complexity |
| vulcanr |
Just not to rely in only one person (each one of us have jobs, responsibilities, family, kids, etc) |
| vulcanr |
and it takes time to review MRs, update d.org, give feedback, etc |
| vulcanr |
@mherchel you are doing great IMHO |
| vulcanr |
but still don't know how you manage all the stuff :slightly_smiling_face: |
| mherchel |
Thanks :slightly_smiling_face: I hope to be able to dedicate a good chunk of time to it this month |
| andrewmacpherson |
Plus/minus for the drop down button works as a concept. |
| andrewmacpherson |
The designs in the issue have a special focus style for the submenu button. I don't think that's a good direction.Better to design focus styles for the site as a whole, rather than focus styles per component.When focus styles vary between components, it's harder to follow focus. |
| andrewmacpherson |
Choosing a signifier for the submenu button is a separate concern from choosing a focus signifier. |
| andrewmacpherson |
plus/minus is good to go, not blocked by a design for focus. |
| vulcanr |
I have a question ( I guess the good place to place it is here) |
| vulcanr |
Are we supporting IE 11? |
| vulcanr |
I spent about 30mins today trying to find the end of support of it by Microsoft |
| vulcanr |
and some places mention January 2020 |
| vulcanr |
if we are targeting Olivero to be in Core for Drupal 9.1 (and Drupal 9 release date is June 2020) do we want/need/have to support IE11? |
| mherchel |
yep. we do support IE11 |
| mherchel |
https://www.drupal.org/node/3079238 |
| mherchel |
And although we’re targeting 9.1. There’s an outside chance we may make 9.0 if we’re ready |
| vulcanr |
ok thats 8.8 |
| vulcanr |
but even doh, 9.0 is released in June |
| mherchel |
From my point of view, we’ll support it until Drupal doesn’t (edited) |
| shaal |
I've been trying to monitor end-of-ie11 closely... so far this is the most accurate -https://gabriellaroche.dev/ie11-death-countdown/ |
| shaal |
:disappointed: |
| mherchel |
I would LOVE LOVE LOVE to not support it |
| vulcanr |
@shaal yeah that's according the end of support for Microsoft Windows 10 |
| vulcanr |
but recent Windows 10 installations don't have IE11 (only emulated via Edge) |
| vulcanr |
anyways its ok if we are supporting it I guess |
| mherchel |
It’s really a discussion out of scope for the theme. We need to discuss this on a more core level |
| vulcanr |
I had to ask :slightly_smiling_face: |
| shaal |
The one potential scenario I read about, is that edge-chromium will become the official replacement (by emulating IE11), and they'll be able to put IE11 to sleep sooner than that. |
| vulcanr |
I have no more issues/questions :slightly_smiling_face: |
| mherchel |
We need to work w lauriii to figure that out. |
| Gábor Hojtsy (he/him) |
@vulcanr while 9.0 is released in June, all of it should be API-ready by end of February (beta release first week of March if we are to make the June date) |
| Gábor Hojtsy (he/him) |
so looking at market share etc will probably not change that much |
| vulcanr |
Yeah I kinda imagined that |
| vulcanr |
I imagined late March but yeah, close enough |
| Gábor Hojtsy (he/him) |
https://www.drupal.org/core/release-cycle-overview#next-development-cycle has dates for the three possible variants of dates we defined based on when we are beta-ready |
| Bhavin Joshi (he/him) |
IE 11 would be a liability. We may provide an option to add additional library/code/script for support it for a while, until it is buried deep. |
| Bhavin Joshi (he/him) |
@Gábor Hojtsy (he/him) That's seems more accurate! Thank you for sharing. |
| andrewmacpherson |
It's only a liability if you're thinking along the lines of "we need X feature". |
| andrewmacpherson |
D8 looks pretty good in IE8, unless you think sidebars are important. |
| Bhavin Joshi (he/him) |
Yes, sometimes it does as general features. But, IE makes a special case |
Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comments
Comment #2
mtiftComment #3
mherchelComment #4
mherchelComment #5
shaalI attended
Comment #6
cbovard CreditAttribution: cbovard as a volunteer commentedI attended.
Comment #7
vulcanr CreditAttribution: vulcanr as a volunteer and at Annertech commentedI attended
Comment #8
starshapedI attended!
Comment #9
alonaoneill CreditAttribution: alonaoneill at Hook 42 commentedI attended!
Comment #10
mikelutzI did not attend.
Comment #11
beautifulmindI attended.
Comment #12
mtift