Problem/Motivation

Tests are failing.

1) Drupal\Tests\content_moderation_notifications\Kernel\NotificationsTest::testEmailDelivery
Drupal\Core\Entity\EntityStorageException: array_flip(): Can only flip STRING and INTEGER values!

/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:846
/var/www/html/core/lib/Drupal/Core/Entity/EntityBase.php:395
/var/www/html/modules/contrib/content_moderation_notifications/tests/src/Kernel/NotificationsTest.php:60

Proposed resolution

Fix them.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 tests_are_failing_ag-3097199-7.patch1.06 KBjhedstrom
#3 content_moderation_notifications-hotfix-for-drupal8-8.patch532 bytesradamiel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Issue summary: View changes
radamiel’s picture

radamiel CreditAttribution: radamiel commented
FileSize
content_moderation_notifications-hotfix-for-drupal8-8.patch532 bytes
berenddeboer’s picture

berenddeboer CreditAttribution: berenddeboer at Xplain Hosting commented

Is this the right patch? I've read something that getLatestRevision() is deprecated, and you should call RevisionableStorageInterface::getLatestRevisionId(). Not sure that's applicable though.

berenddeboer’s picture

berenddeboer CreditAttribution: berenddeboer at Xplain Hosting commented
Status: Active » Reviewed & tested by the community

Regardless, the patch fixes the issue.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Reviewed & tested by the community » Needs review

We should probably call the non-deprecated method here instead I think.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
FileSize
tests_are_failing_ag-3097199-7.patch1.06 KB

This replaces the deprecated method call.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Human Rights Watch commented

  • jhedstrom committed 931a8d5 on 8.x-3.x 
    Issue #3097199 by jhedstrom, radamiel, berenddeboer: Tests are failing...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Human Rights Watch commented
Status: Needs review » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.