Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
There's comments in the code that we'd like to make notifications to site admin as a configurable option. Let's do that.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#13 | 3097210-13.patch | 5.9 KB | iyyappan.govind |
| |||
#12 | interdiff-11-12.txt | 2.58 KB | iyyappan.govind |
#12 | 3097210-12.patch | 5.89 KB | iyyappan.govind |
| |||
#11 | interdiff-8-11.txt | 1.4 KB | iyyappan.govind |
#11 | 3097210-11.patch | 5.54 KB | iyyappan.govind |
Comments
Comment #2
heddnComment #3
heddnComment #4
heddnComment #5
heddnComment #6
heddnComment #7
jhedstromThis needs a reroll.
Comment #8
iyyappan.govindHi jhedstrom,
Please find the rerolled patch.
Comment #9
iyyappan.govindComment #10
jhedstromThis is looking good. Let's add a test with this set to true, and also to false, in
NotificationsTest::testEmailDelivery()
.Comment #11
iyyappan.govindHi jhedstrom,
I have added the test. Please find the patch and interdiff.
Comment #12
iyyappan.govindUpdated the test.
Comment #13
iyyappan.govindFixed the coding standard issues in the above #12 patch.
Comment #15
jhedstromThis looks good. Thanks all!
Comment #17
bkosbornePHPMailer, used by the SMTP module, is not compatible with this. In that library it's not valid to have an empty recipient. I'll create a follow up.