Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

Status: Active » Needs review
FileSize
4.05 KB
heddn’s picture

heddn’s picture

heddn’s picture

FileSize
721 bytes
4.02 KB
heddn’s picture

FileSize
459 bytes
4.05 KB
jhedstrom’s picture

Status: Needs review » Needs work

This needs a reroll.

iyyappan.govind’s picture

Hi jhedstrom,

Please find the rerolled patch.

iyyappan.govind’s picture

Status: Needs work » Needs review
jhedstrom’s picture

Issue tags: +Needs tests

This is looking good. Let's add a test with this set to true, and also to false, in NotificationsTest::testEmailDelivery().

iyyappan.govind’s picture

Hi jhedstrom,

I have added the test. Please find the patch and interdiff.

iyyappan.govind’s picture

Updated the test.

iyyappan.govind’s picture

Fixed the coding standard issues in the above #12 patch.

jhedstrom’s picture

Status: Needs review » Fixed
Issue tags: -Needs tests

This looks good. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bkosborne’s picture

PHPMailer, used by the SMTP module, is not compatible with this. In that library it's not valid to have an empty recipient. I'll create a follow up.