Problem/Motivation

If a user uploads a file with a bad line ending. For example mac line endings. The import will fail.

Proposed resolution

Let php detect file endings

Remaining tasks

Write a patch with a test.

User interface changes

none

API changes

none.

Data model changes

none.

Release notes snippet

none

CommentFileSizeAuthor
#3 price_list_mac_line_endings.txt111 byteseiriksm
#2 3097319.patch2.8 KBeiriksm
#2 3097319-test-only.patch2.1 KBeiriksm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eiriksm created an issue. See original summary.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS, Violinist commented
Status: Active » Needs review
FileSize
3097319-test-only.patch2.1 KB
3097319.patch2.8 KB
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS, Violinist commented
FileSize
price_list_mac_line_endings.txt111 bytes

If someone wants to manually test this, here is the mac file ending price list, for convenience.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
Status: Needs review » Fixed

Committed! Thanks!

  • jsacksick committed 6fe0f08 on 8.x-2.x authored by eiriksm 
    Issue #3097319 by eiriksm: Support csv files with different platform...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.