drupal-check against captcha_questions 8.x-1.x-dev (30 Nov 2019)

➜  d9readiness vendor/mglaman/drupal-check/drupal-check web/modules/contrib/captcha_questions
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -----------------------------------------------------------------------------------
  Line   captcha_questions.module
 ------ -----------------------------------------------------------------------------------
  68     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
         in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
         mb_strtolower() instead.
  81     Call to deprecated function db_insert():
         as of Drupal 8.0.x, will be removed in Drupal 9.0.0. Instead, get
         a database connection injected into your service from the container and
         call insert() on it. For example,
 ------ -----------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   captcha_questions_dblog/captcha_questions_dblog.install
 ------ ----------------------------------------------------------------------
  79     Call to deprecated method l() of class Drupal:
         in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Link instead.
         Example:
  81     Call to deprecated function drupal_set_message():
         in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/CaptchaQuestionsSettingsForm.php
 ------ ----------------------------------------------------------------------
  259    Call to deprecated function drupal_set_message():
         in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  263    Call to deprecated function drupal_set_message():
         in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------


 [ERROR] Found 6 errors

Upgrade status report warnings against captcha_questions 8.x-1.x-dev (30 Nov 2019)

Add core_version_requirement: ^8 || ^9 to captcha_questions.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yogeshmpawar created an issue. See original summary.

yogeshmpawar’s picture

Status: Needs work » Active
yogeshmpawar’s picture

Issue tags: -Drupal 9 compatibility
Gnanagowthaman sankar’s picture

Hi @yogeshmpawar

Here by attached the patch. Please let me know for any changes.

Thanks & Regards,
Gnanagowthaman sankar

Gnanagowthaman sankar’s picture

Status: Active » Needs review
FileSize
3.5 KB

Patch

Thanks & Regards,
Gnanagowthaman sankar

yogeshmpawar’s picture

Issue tags: +Drupal 9 compatibility
Gnanagowthaman sankar’s picture

Please ignore the previous.

  • yogeshmpawar committed ff76b58 on 8.x-1.x
    Issue #3097780 by Gnanagowthaman sankar, yogeshmpawar: Drupal 9...
yogeshmpawar’s picture

Status: Needs review » Fixed

Committed & Pushed to 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.