Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#9 | 3097879-9.patch | 11.68 KB | andypost |
#9 | interdiff.txt | 826 bytes | andypost |
#7 | interdiff.txt | 692 bytes | andypost |
#2 | 3097879.patch | 11.55 KB | longwave |
Comments
Comment #2
longwaveComment #3
andypostIt looks good to go, except the one hunk - maybe better to convert message to "is removed in drupal:10.0.0" because otherwise it will be hard to catch
I think it makes sense to keep this to prevent incomplete conversions of deprecated code
Comment #4
BerdirDoes it even do anything with it afterwards?
I don't think we need to keep it or change it to D10. What we could maybe do is throw an exception and make it fail hard?
Comment #5
andypostMaybe convert it to
assert()
?Comment #6
BerdirYes, that sounds like a good idea.
Comment #7
andypostKind of it should work
Comment #8
andypostAs setup fails this option is used some places...
Comment #9
andypostCondition should be negated
Comment #10
BerdirThe postgresql tests fails look unrelated to me, and this looks good overall.
Comment #11
larowlanAccording to https://www.drupal.org/pift-ci-job/1550844 there are no fails in Postgres ATM
Queueing up new test runs to be safe™
Comment #12
larowlanComment #13
larowlanActually, those fails are on PHP7.2, which isn't supported on D9 anymore. Queued up a MYSQL run on 7.3
Comment #14
alexpottCommitted 0281f2f and pushed to 9.0.x. Thanks!