Problem/Motivation

Child issue for #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch

Proposed resolution

Remove menu_ui.module BC layers

CommentFileSizeAuthor
#10 3098153-10.patch3.88 KBlongwave
#2 3098153.patch3.9 KBrenatog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RenatoG created an issue. See original summary.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Active » Needs review
FileSize
3098153.patch3.9 KB
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Related issues: +#3015699: Properly deprecate MENU_MAX_MENU_NAME_LENGTH_UI

I think this is going to need to wait for #3015699: Properly deprecate MENU_MAX_MENU_NAME_LENGTH_UI, or leave the constant in place and defer to that issue for the final removal.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

I agree.

I think we can wait #3015699: Properly deprecate MENU_MAX_MENU_NAME_LENGTH_UI IMHO

Status: Needs review » Needs work

The last submitted patch, 2: 3098153.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Postponed
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Per my comment over there, I'm not sure if we can deprecate that constant still for D9, so it might make sense to keep that for now. Not that urgent to get in though.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Postponed » Needs work
Issue tags: +Needs reroll

#3015699: Properly deprecate MENU_MAX_MENU_NAME_LENGTH_UI landed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3098153-10.patch3.88 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Manually confirmed that with this patch applied, zero occurrences of @deprecated remain in core/modules/menu_ui.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 09b78ff and pushed to 9.0.x. Thanks!

  • alexpott committed 09b78ff on 9.0.x 
    Issue #3098153 by RenatoG, longwave: Remove menu_ui.module BC layers

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.