This module will help users to upload compressed HTML files to create node and uploaded file will be listed down into provided dashboard tab from where then and manage the file as well.

Project link

https://www.drupal.org/project/html_importer

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/html_importer.git

PAReview Checklist

https://pareview.sh/pareview/https-git.drupal.org-project-html_importer

Comments

PratikshaD created an issue. See original summary.

rosemaryreilman’s picture

Status: Active » Needs work

Hi! Thanks for your contribution. Right off the bat, the project name is html_importer but your code uses html_import. It would be easier for users downloading and using your site to stay consistent with the naming.

Also there are several things to check on your PAReview and to fix. https://pareview.sh/pareview/https-git.drupal.org-project-html_importer

rosemaryreilman’s picture

Issue summary: View changes

Added pareview link to main issue body

PratikshaD’s picture

Hi @rosemarystanley, I have addressed your comments. please check and confirm if there will any further improvement requires.

PratikshaD’s picture

Status: Needs work » Active
apaderno’s picture

Issue summary: View changes
Status: Active » Needs work

8.x and dev are wrong names for branches. A correct one would be 8.x-1.x, for example. A new branch needs to be created, made the default one, and the other branches need to be removed.

apaderno’s picture

Title: [D8]HTML importer » [D8] HTML importer
PratikshaD’s picture

Branch name updated as per the suggestion

PratikshaD’s picture

Status: Needs work » Active
PratikshaD’s picture

Status: Active » Needs review
PratikshaD’s picture

hi @kiamlaluno @coltrane anyone please help me for further process, how can I make my contributed module under security advisory policy.

apaderno’s picture

PratikshaD’s picture

hi @kiamlaluno,

Please suggest if any further action required to be taken on it.

Regards,
Pratiksha dubey

apaderno’s picture

We are just waiting for reviews.

klausi’s picture

Issue summary: View changes
klausi’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for your contribution!

Review of the 8.x-1.x branch:

  1. Sounds like your module depends on the node module, but that is not listed in html_importer.info.yml?
  2. user.role.creator.yml: Drupal sites probably want to define their own roles and don't want a contributed module to ship a "creator" role. That could easily clash with an existing creator role on their site, so probably best if you remove the role.
  3. ImportHtmlForm: why is this class a ConfigFormBase? You are no saving any configuration entity here? I think it should just extend from FormBase?
  4. file_default_scheme() and file_prepare_directory() are deprecated. Please check your code for deprecated functions and use the suggested replacemnts instead.
  5. bathProcess(): typo, should this be called batchProcess() instead?
  6. bathProcess(): why do you catch Throwable and then just re-throw it as exception? Please add a code comment or remove it.
  7. nodeDashboard(): you are performing one query for each file iteration, which can be expensive when there are many files. Could be optimized to load all file IDs at once I think.

Did not see any security issue otherwise, looks good to me!

apaderno’s picture

Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

apaderno’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.