Needs to do the "TODOs" left in code in the parent issue.

CommentFileSizeAuthor
#7 interdiff-3099671-6-7.txt2.05 KBGrimreaper
#7 entity_visibility_preview-preview_form_ustem_pluggable-3099671-7.patch25.38 KBGrimreaper
#6 interdiff-3099671-5-6.txt479 bytesGrimreaper
#6 entity_visibility_preview-preview_form_ustem_pluggable-3099671-6.patch24.7 KBGrimreaper
#5 interdiff-3099671-3-5.txt5.32 KBGrimreaper
#5 entity_visibility_preview-preview_form_ustem_pluggable-3099671-5.patch24.7 KBGrimreaper
#3 entity_visibility_preview-preview_form_ustem_pluggable-3099671-3.patch25.39 KBPiegefull
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper created an issue. See original summary.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented

I am handling the JS TODO in #3100004: Use JS to display message on active preview to avoid cache variation

Piegefull’s picture

Piegefull CreditAttribution: Piegefull at Smile commented
Assigned: Piegefull » Grimreaper
Status: Active » Needs review
FileSize
entity_visibility_preview-preview_form_ustem_pluggable-3099671-3.patch25.39 KB
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Status: Needs review » Needs work 
  1. +++ b/src/EntityVisibilityPreviewConditionPluginBase.php
@@ -5,12 +5,57 @@ declare(strict_types = 1);
+   * @param \Drupal\entity_visibility_preview\Service\SessionManager $session_manager

    SessionManagerInterface 

  2. +++ b/src/EntityVisibilityPreviewConditionPluginBase.php
@@ -33,4 +78,32 @@ abstract class EntityVisibilityPreviewConditionPluginBase extends PluginBase imp
+

    Removing empty lines. 

  3. +++ b/src/Plugin/EntityVisibilityPreviewCondition/DateRangeCondition.php
@@ -99,8 +92,8 @@ class DateRangeCondition extends EntityVisibilityPreviewConditionPluginBase impl
       $container->get('datetime.time'),

    I will show you how to extend with dependency injection.

Ok, we will optimize the plugin heritage for the dependency injection.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Status: Needs work » Needs review
FileSize
entity_visibility_preview-preview_form_ustem_pluggable-3099671-5.patch24.7 KB
interdiff-3099671-3-5.txt5.32 KB
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
FileSize
entity_visibility_preview-preview_form_ustem_pluggable-3099671-6.patch24.7 KB
interdiff-3099671-5-6.txt479 bytes
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
FileSize
entity_visibility_preview-preview_form_ustem_pluggable-3099671-7.patch25.38 KB
interdiff-3099671-6-7.txt2.05 KB

As the pluginBase class do not have a create method we can't use the instance in the "create" method.

  • Piegefull authored a3efa85 on 8.x-1.x 
    Issue #3099671 by Grimreaper, Piegefull: Make the preview form/system...
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.