Drupal 9 readiness meeting / 6 January 2020 [#3099840]

Meeting will happen in #d9readiness on drupal.slack.com.

Hello and welcome to this Drupal 9 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 9 upgrade of their sites are also welcome.
➤ Usually happens every other Monday at 19:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3099840`
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

tedbow	:ocean:Ted from Ithaca, USA
Alona Oneill	Alona from San Francisco. Taking notes for blog
TravisCarden	Travis Carden (Acquia) from North Carolina, USA. (edited)
Gábor Hojtsy (he/him)	:wave:
greg.1.anderson	Greg Anderson from San Francisco. Lurking in case composer dependency issues et. al. come up (edited)
mikelutz	Hello.
mradcliffe	Hi, Matthew here from Columbus, USA
vuil	Drupal modules contributor
shaal	:wave:
Nick Wilde (he/him) - DC 2020 DevOps Session Team	Nick, he/him, Victoria BC :flag-ca: , contrib dev, Taoti Creative
catch	Hello. Will be more around in 15 mins and try to catch up.
damienmckenna	Damien from NH, USA.
wimleers (he/him)	:wave: — after the fact

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

tedbow	#2550717: [JS] Replace jQuery.cookie with JS-cookie and provide a BC layer could use a review
berdir	state of contrib might be a possible topic, although possibly better next time when we have fresh data again, missed it by a few hours this time :slightly_smiling_face:

2️⃣ Drupal 9 alpha status

Gábor Hojtsy (he/him)	requirements are listed at #2608062: [META] Requirements for tagging Drupal 9.0.0-alpha1
Gábor Hojtsy (he/him)	there is no set date for alpha, but my understanding is that this week is a bugfix release window for Drupal 8 and next week is a possible release window for Drupal 9 alpha if all criteria is met (edited)
Gábor Hojtsy (he/him)	#3074993: Use "current" in update URLs instead of CORE_COMPATIBILITY to retrieve all future updates is the only remaining core requirement which was RTBC for a while but currently needs work, needs some minor fixes and a test addition (edited)
Gábor Hojtsy (he/him)	there are two should haves, #3099876: Establish a packaging pipeline queue is one @mixologic is working on for the bugfix release window for this week :slightly_smiling_face:
Gábor Hojtsy (he/him)	and #3088246: [policy, no patch] How to handle Drupal 8.9.x deprecations is open for feedback :slightly_smiling_face:
tedbow	I just posted a patch for last review on #3074993: Use "current" in update URLs instead of CORE_COMPATIBILITY to retrieve all future updates
berdir	Is #3084063: Use information in info.yml files to determine project requirements somehow tracked as a alpha/beta related/should-have/something? Many modules are working around it now by adding their own composer.json as part of D9 preparation but there are still situations where that doesn't work, like sub-module meta-packages
tedbow	it blocks #3050374: Create Drupal 9 stable theme
Gábor Hojtsy (he/him)	@tedbow but does that block Drupal 9 release?
tedbow	I think it does. @bnjmnm was working on it. He might know
tedbow	but it is part of the proposed solution here #3079680: [META] Requirements for tagging Drupal 9.0.0-beta1
berdir	@Gábor Hojtsy (he/him) it blocks testing against D9 for payment.module for example and possibly other projects with complex dependencies too (commerce ecosystem for example)

3️⃣ State of deprecated API removals

Gábor Hojtsy (he/him)	this is going super well, we have a visualization at https://dev.acquia.com/drupal9/deprecation_status/graphs
Gábor Hojtsy (he/him)	Screenshot 2020-01-03 at 19.13.56.png
Gábor Hojtsy (he/him)	well over half of it is done, but we are also more than half-way in terms of time left if we want to make it to the planned beta date on first week of March
Gábor Hojtsy (he/him)	#3087644: Remove Drupal 8 updates up to and including 88** blocks a lot of the remaining ones according to @berdir
Gábor Hojtsy (he/him)	so helping there would be really appreciated
Gábor Hojtsy (he/him)	he also opened a bunch of actual BC layer removal issues that can be worked on as well in the meantime #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch#comment-13410877
berdir	yeah, I'll try to pick up that issue and related ones again when I find the motivation to do so
Gábor Hojtsy (he/him)	thanks @berdir, we need more people doing these also :slightly_smiling_face:

4️⃣ Dependency updates

4️⃣ .1️⃣ Backend dependencies (edited)

Gábor Hojtsy (he/him)	Congrats on landing #3091418: Update composer dependencies on 9.0.x following PHP 7.2 requirement
Gábor Hojtsy (he/him)	@Manuel Garcia, @jibran, @tedbow, @TravisCarden, @xjm, @catch, @greg.1.anderson, @Mile23, @berdir, @hussainweb :clap:
greg.1.anderson	Related follow-on issues:#3104473: Use version of guzzlehttp/guzzle ^6.5.2
catch	Also this for sorting out the Doctrine updates which are very confusing: #3104265: Update Composer dependencies on Doctrine components in 9.0.x
Gábor Hojtsy (he/him)	@catch should any of those be alpha requirements / should haves? :)
catch	@gabor definitely should haves. The simple doctrine updates should be simple. The other ones probably beta blockers?
Gábor Hojtsy (he/him)	@catch can you update the respective issues? :slightly_smiling_face:
catch	@Gábor Hojtsy (he/him) done, added to the alpha as a should have, and added to the php dependencies big meta issue.

4️⃣ .2️⃣ Frontend dependencies

Gábor Hojtsy (he/him)	@tedbow says #2550717: [JS] Replace jQuery.cookie with JS-cookie and provide a BC layer could use a review :slightly_smiling_face:
mradcliffe	Oh, I think I just figured out my bug. I need to use withConverter in the setter part of the shim too. :facepalm:
mradcliffe	#2550717: [JS] Replace jQuery.cookie with JS-cookie and provide a BC layer#comment-13412938 :partyparrot: go test bot go

5️⃣ Tooling to prepare contrib/custom code for Drupal 9

5️⃣ .1️⃣ State of all of contrib

Gábor Hojtsy (he/him)	There is a regular job at https://dispatcher.drupalci.org/job/phpstan that is just now running again and will hopefully provided up to date data later today
Gábor Hojtsy (he/him)	will display that at https://dev.acquia.com/drupal9/deprecation_status once available :slightly_smiling_face: that is currently showing the Dec 14th state
berdir	@Gábor Hojtsy (he/him) how automated is the process between having that data and putting it on the website? :wink:
Gábor Hojtsy (he/him)	@berdir its all in the deprecation_status project, the scripts branch contains the script, that need to run and committed to the 8.x-1.x branch which then goes up on the site right away :slightly_smiling_face: there is a human component involved so bad data updates don’t destroy valid data, if the source was not valid/useful
berdir	ok, but then it should be up there soon, nice. did a few releases, for example payment, so that alone should bring it down by ~700 or so :wink:
Gábor Hojtsy (he/him)	woot

5️⃣ .2️⃣ Drupal-check / phpstan-drupal updates

mglaman	:upside_down_face: drupal-check needs to be updated for 0.12, I didn’t work over the holiday break
Gábor Hojtsy (he/him)	:slightly_smiling_face: @mglaman did make a 0.12 release of phpstan-drupal available that is now based on phpstan 0.12 :slightly_smiling_face:
Gábor Hojtsy (he/him)	@mglaman you may have seen https://drupal.slack.com/archives/CDDD98AMN/p1578300729048300
Gábor Hojtsy (he/him)	good news that phpstan now wraps all its dependencies, so there will be no conflicts with other packages :slightly_smiling_face:
mglaman	yeah, that was the big BC for us and headache for phpstan-drupal
mglaman	and I can deprecate my junit formatter
mglaman	or not, mine looks more verbose

5️⃣ .3️⃣ Upgrade status

Gábor Hojtsy (he/him)	There is a https://www.drupal.org/project/upgrade_status/releases/8.x-2.0-alpha1 as of a few hours ago which is based on phsptan 0.12 too :slightly_smiling_face:
Gábor Hojtsy (he/him)	this now uses exec() to run phpstan, so there will be less problems going forward when they change internal APIs :slightly_smiling_face:
Gábor Hojtsy (he/him)	that said, this branch will not work if you have exec() disabled, but this module should not be run on production anyway :stuck_out_tongue:
andypost	btw symfony/process is one of core dependencies, could be reused instead of exec()core8$ composer why symfony/processcomposer/composer 1.9.1 requires symfony/process (^2.7 \|\| ^3.0 \|\| ^4.0) drupal/core 8.9.x-dev requires symfony/process (~3.4.0) (edited)
Gábor Hojtsy (he/him)	@andypost does that use exec() after all though?

5️⃣ .4️⃣ rector automated fixes

Gábor Hojtsy (he/him)	I started working on https://www.drupal.org/project/upgrade_status_rector which intends to integrate rector into the upgrade status UI :slightly_smiling_face:
Gábor Hojtsy (he/him)	with the tighter packaged phpstan 0.12, this should be much less pain of conflicting dependencies :dancerwookie:
Gábor Hojtsy (he/him)	I only have some local proof of concept, this would be more interesting in a week or so :fingerscrossed:
Gábor Hojtsy (he/him)	@shaal will be happy :smile:
shaal	:heart_eyes:

6️⃣ Multilingual migrations needs testers

Gábor Hojtsy (he/him)	#2208401: [META] Remaining multilingual migration paths is one of the beta blockers that is basically ready in terms of implementation but need people to test it out in some real life scenarios ideally
Gábor Hojtsy (he/him)	@quietone is around to see results :)

7️⃣ The Drupal 9 release date: June, August or December.

Gábor Hojtsy (he/him)	I put up this image on the core releases page last week: https://www.drupal.org/files/Drupal9Scenarios.png(59 kB)https://www.drupal.org/files/Drupal9Scenarios.png
Gábor Hojtsy (he/him)	it is worth zooming into to understand the possible scenarios
Gábor Hojtsy (he/him)	they are also detailed in tables at https://www.drupal.org/core/release-cycle-overview
Gábor Hojtsy (he/him)	in short, there a whole lot of beta requirements that would all need to be met in the coming 8 weeks for the June date to be realistic: #3079680: [META] Requirements for tagging Drupal 9.0.0-beta1
damienmckenna	Just to mention it, a huge thank you to Gábor and everyone who compiled all of this information, it's really helpful for folks trying to get an understanding of everything.
Gábor Hojtsy (he/him)	:thumbsup: