Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
drupal-check views_field_view
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ------------------------------------------------------------------------------------------------------------
Line src/Tests/ViewFieldUITest.php
------ -------------------------------------------------------------------------------------------------------------
15 Class Drupal\views_field_view\Tests\ViewFieldUITest extends deprecated class Drupal\views_ui\Tests\UITestBase:
in drupal:8.4.0 and is removed from drupal:9.0.0.
Use \Drupal\Tests\views_ui\Functional\UITestBase.
42 Call to method setUp() of deprecated class Drupal\views_ui\Tests\UITestBase:
in drupal:8.4.0 and is removed from drupal:9.0.0.
Use \Drupal\Tests\views_ui\Functional\UITestBase.
------ --------------------------------------------------------------------------------------------------------------
[ERROR] Found 2 errors
Comment | File | Size | Author |
---|---|---|---|
#19 | 3100149-drupal-9-compatibility.4.patch | 3.19 KB | xeM8VfDh |
#3 | 3100149-3.patch | 411 bytes | John Cook |
Comments
Comment #2
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #3
John Cook CreditAttribution: John Cook at Creode commentedI've created a patch to fix the reported errors.
Post patch results:
Comment #4
John Cook CreditAttribution: John Cook at Creode commentedComment #5
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #6
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #7
xeM8VfDh CreditAttribution: xeM8VfDh commentedis this ready to go?
Comment #8
xeM8VfDh CreditAttribution: xeM8VfDh commented(deleted)
Comment #9
xeM8VfDh CreditAttribution: xeM8VfDh commentedsorry, new to this... trying again with drupal_9_compatibility_diff.patch (
Comment #10
xeM8VfDh CreditAttribution: xeM8VfDh commentedOne last try, following drupal patching instructions: 3100149-drupal-9-compatibility.patch
Comment #11
xeM8VfDh CreditAttribution: xeM8VfDh commentedComment #12
xeM8VfDh CreditAttribution: xeM8VfDh commentedComment #13
xeM8VfDh CreditAttribution: xeM8VfDh commented3100149-drupal-9-compatibility.2.patch
Comment #14
xeM8VfDh CreditAttribution: xeM8VfDh commented3100149-drupal-9-compatibility.3.patch
Comment #15
xeM8VfDh CreditAttribution: xeM8VfDh commentedComment #16
xeM8VfDh CreditAttribution: xeM8VfDh commenteddrupal-check
is passing, as are unit tests on 7.1. Since I'm not sure anyone will every review this, or if this module is even maintained, I am marking this as reviewed (by myself).Comment #17
jibranLet's add the changes from the patch from #3130966: Drupal 9 readiness here as well.
Comment #18
xeM8VfDh CreditAttribution: xeM8VfDh commentedgreatm go for it!
Comment #19
xeM8VfDh CreditAttribution: xeM8VfDh commentednever mind, I've attached 3100149-drupal-9-compatibility.4.patch to take care of this, please review @jibran
Comment #20
xeM8VfDh CreditAttribution: xeM8VfDh commentedComment #21
xeM8VfDh CreditAttribution: xeM8VfDh commented@jibran can you review again, thanks!
Comment #22
jibranLooks good now. Thanks!
Comment #24
jibranAdding @ravimane23 to credit list from #3130966: Drupal 9 readiness.
Comment #26
jibranCommitted and pushed to 8.x-1.x. Thanks all!
Comment #27
jibranWe miesed one here
modules/views_field_view/tests/views_field_view_test_config/views_field_view_test_config.info.yml
Comment #28
xeM8VfDh CreditAttribution: xeM8VfDh commentedthanks @jibran, see 3138306
Comment #29
xeM8VfDh CreditAttribution: xeM8VfDh commented