"Available on current domain" does not work properly for default domains

Did you "rebuild node access" as instructed after installing the module?

I also disagree. No domain information does not mean "published to the default domain."

This is not a bug. When you install the module, core prompts you (on all admin pages) to rebuild node access.

Saving a node with no domain assignments (view the UI), assigns it to the default domain. See line 83 of domain_access.module.

    // If there are no domains set, use the current one.
    $domains = \Drupal::service('domain_access.manager')->getAccessValues($translation);
    /** @var \Drupal\domain\DomainInterface $active */
    if (empty($domains) && $active = \Drupal::service('domain.negotiator')->getActiveDomain()) {
      $domains[$active->id()] = $active->getDomainId();
    }

Is this _not_ the behavior you see after rebuilding node access?

My apologies, I get a lot of false bug reports because people don't rebuild node access.

I just looked at the logic of the patch, and the problem is indeed with how Views handles this case.

Our node access records are stored properly, but there is no data in the node field.

This approach is probably easier than adding default values to all existing nodes on install, but I wonder if we should be doing that as well? Probably not, because we end up chasing dependencies in that case.

I also see that this addresses the // @TODO proper handling of NULL? comment, which is great.

I think at this point we should leave the DISTINCT. Taking it out would require all Views written with this module to be edited. Removing it also creates a bit of a support nightmare, as everyone will be asking why there are now duplicates in their views.

What about that DISTINCT causes issues with other Views?

Rerolled patch #3 without removing DISTINCT from the query per comment #7.

Committed! Thanks!