PHPCS Errors [#3101319]

Problem / Motivation

$ ~/.composer/vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme $BUILDSDIR/$PROJ_DOCROOT/modules/custom/schema_metatag

FILE: ...ugin/metatag/Tag/SchemaOrganizationOpeningHoursSpecification.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | Line exceeds 80 characters; contains 88 characters
----------------------------------------------------------------------


FILE: ...ization/src/Plugin/metatag/Tag/SchemaOrganizationDescription.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 42 | ERROR | [x] Expected 1 blank line after function; 0 found
 43 | ERROR | [x] The closing brace for the class must have an empty
    |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...src/Plugin/metatag/Tag/SchemaOrganizationAcceptsReservations.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: ...ustom/schema_metatag/tests/src/Unit/SchemaMetatagManagerTest.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 106 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
 136 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
 342 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
 364 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...om/schema_metatag/tests/src/Functional/SchemaMetatagTagsTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 69 | ERROR | [x] Array closing indentation error, expected 2 spaces
    |       |     but found 3
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...eark/docroot/modules/custom/schema_metatag/schema_metatag.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../modules/custom/schema_metatag/schema_audit/src/SchemaClient.php
----------------------------------------------------------------------
FOUND 23 ERRORS AFFECTING 20 LINES
----------------------------------------------------------------------
  10 | ERROR | [x] Missing class doc comment
  26 | ERROR | [ ] Parameter $httpClient is not described in comment
  26 | ERROR | [ ] Parameter $moduleHandler is not described in
     |       |     comment
  29 | ERROR | [ ] Missing parameter comment
  29 | ERROR | [ ] Doc comment for parameter $http_client does not
     |       |     match actual variable name $moduleHandler
  30 | ERROR | [ ] Missing parameter comment
  30 | ERROR | [ ] Missing parameter name
 112 | ERROR | [ ] Parameter $google is not described in comment
 121 | ERROR | [ ] Type hint "array" missing for $drupal
 181 | ERROR | [x] Missing function doc comment
 201 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 7
 222 | ERROR | [x] No space found before comment text; expected "//
     |       |     $class_checkbox[] = 'checkbox';" but found
     |       |     "//$class_checkbox[] = 'checkbox';"
 225 | ERROR | [x] No space found before comment text; expected "//
     |       |     $property_class_checkbox[] = 'checkbox';" but
     |       |     found "//$property_class_checkbox[] = 'checkbox';"
 228 | ERROR | [ ] If the line declaring an array spans longer than
     |       |     80 characters, each element should be broken into
     |       |     its own line
 237 | ERROR | [x] No space found before comment text; expected "//
     |       |     $property_class_checkbox[] = 'checkbox';" but
     |       |     found "//$property_class_checkbox[] = 'checkbox';"
 262 | ERROR | [x] Parameter comment must end with a full stop
 313 | ERROR | [ ] Type hint "array" missing for $objects
 330 | ERROR | [ ] Type hint "array" missing for $objects
 350 | ERROR | [ ] Parameter $objects is not described in comment
 353 | ERROR | [ ] Doc comment for parameter $classes does not match
     |       |     actual variable name $parent_name
 373 | ERROR | [ ] Parameter $objects is not described in comment
 378 | ERROR | [ ] Doc comment for parameter $classes does not match
     |       |     actual variable name $parent_name
 412 | ERROR | [x] Parameter comment must end with a full stop
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../modules/custom/schema_metatag/schema_audit/src/DrupalClient.php
----------------------------------------------------------------------
FOUND 15 ERRORS AND 1 WARNING AFFECTING 15 LINES
----------------------------------------------------------------------
   5 | ERROR   | [x] Missing class doc comment
   7 | ERROR   | [ ] Missing member variable doc comment
  40 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
  42 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "FALSE" but found "false"
  65 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, question marks, colons, or
     |         |     closing parentheses
  79 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, question marks, colons, or
     |         |     closing parentheses
  83 | ERROR   | [ ] If the line declaring an array spans longer than
     |         |     80 characters, each element should be broken
     |         |     into its own line
  88 | ERROR   | [x] Concat operator must be surrounded by a single
     |         |     space
 135 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: '.php'
 137 | ERROR   | [x] Space after closing parenthesis of function call
     |         |     prohibited
 137 | ERROR   | [x] Space found before semicolon; expected ");" but
     |         |     found ") ;"
 258 | ERROR   | [ ] Missing parameter name
 303 | ERROR   | [x] Array indentation error, expected 12 spaces but
     |         |     found 13
 304 | ERROR   | [x] Array indentation error, expected 12 spaces but
     |         |     found 13
 410 | ERROR   | [x] Expected 1 blank line after function; 0 found
 411 | ERROR   | [x] The closing brace for the class must have an
     |         |     empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../modules/custom/schema_metatag/schema_audit/src/GoogleClient.php
----------------------------------------------------------------------
FOUND 56 ERRORS AND 19 WARNINGS AFFECTING 52 LINES
----------------------------------------------------------------------
   3 | ERROR   | [x] There must be one blank line after the namespace
     |         |     declaration
   6 | ERROR   | [x] Missing class doc comment
  17 | ERROR   | [x] Additional blank lines found at end of doc
     |         |     comment
  27 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
  29 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "FALSE" but found "false"
  81 | ERROR   | [ ] Parameter $deltas is not described in comment
  98 | ERROR   | [x] Line indented incorrectly; expected 12 spaces,
     |         |     found 11
 118 | ERROR   | [x] Closing brace indented incorrectly; expected 11
     |         |     spaces, found 12
 141 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 142 | WARNING | [ ] Code after the RETURN statement on line 141
     |         |     cannot be executed
 142 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 145 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 151 | WARNING | [ ] Code after the RETURN statement on line 145
     |         |     cannot be executed
 151 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 154 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 160 | WARNING | [ ] Code after the RETURN statement on line 154
     |         |     cannot be executed
 160 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 163 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 169 | WARNING | [ ] Code after the RETURN statement on line 163
     |         |     cannot be executed
 169 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 172 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 178 | WARNING | [ ] Code after the RETURN statement on line 172
     |         |     cannot be executed
 178 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 181 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 187 | WARNING | [ ] Code after the RETURN statement on line 181
     |         |     cannot be executed
 187 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 190 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 196 | WARNING | [ ] Code after the RETURN statement on line 190
     |         |     cannot be executed
 196 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 199 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 209 | WARNING | [ ] Code after the RETURN statement on line 199
     |         |     cannot be executed
 209 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 212 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 218 | WARNING | [ ] Code after the RETURN statement on line 212
     |         |     cannot be executed
 218 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 221 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 224 | ERROR   | [x] Expected one space after the comma, 0 found
 235 | WARNING | [ ] Code after the RETURN statement on line 221
     |         |     cannot be executed
 235 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 238 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 244 | WARNING | [ ] Code after the RETURN statement on line 238
     |         |     cannot be executed
 244 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 247 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 250 | ERROR   | [x] Expected one space after the comma, 0 found
 250 | ERROR   | [x] Expected one space after the comma, 0 found
 250 | ERROR   | [x] Expected one space after the comma, 0 found
 250 | ERROR   | [x] Expected one space after the comma, 0 found
 250 | ERROR   | [x] Expected one space after the comma, 0 found
 253 | WARNING | [ ] Code after the RETURN statement on line 247
     |         |     cannot be executed
 253 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 256 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 259 | ERROR   | [x] Expected one space after the comma, 0 found
 262 | WARNING | [ ] Code after the RETURN statement on line 256
     |         |     cannot be executed
 262 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 265 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 271 | WARNING | [ ] Code after the RETURN statement on line 265
     |         |     cannot be executed
 271 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 274 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 281 | ERROR   | [x] Expected one space after the comma, 0 found
 284 | WARNING | [ ] Code after the RETURN statement on line 274
     |         |     cannot be executed
 284 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 287 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 305 | WARNING | [ ] Code after the RETURN statement on line 287
     |         |     cannot be executed
 305 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 308 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 322 | WARNING | [ ] Code after the RETURN statement on line 308
     |         |     cannot be executed
 322 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 325 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 328 | ERROR   | [x] Expected one space after the comma, 0 found
 332 | ERROR   | [x] Expected one space after the comma, 0 found
 336 | ERROR   | [x] Expected one space after the comma, 0 found
 355 | WARNING | [ ] Code after the RETURN statement on line 325
     |         |     cannot be executed
 355 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 364 | WARNING | [ ] Code after the RETURN statement on line 358
     |         |     cannot be executed
 364 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
----------------------------------------------------------------------
PHPCBF CAN FIX THE 55 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ustom/schema_metatag/schema_audit/src/Plugin/Block/TestBlock.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  3 | ERROR | [x] Namespaced classes, interfaces and traits should
    |       |     not begin with a file doc comment
 45 | ERROR | [x] Expected 1 space after "=>"; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...tatag/schema_movie/src/Plugin/metatag/Tag/SchemaMovieHasPart.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     1
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ark/docroot/modules/custom/schema_metatag/schema_metatag.install
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  94 | ERROR | [x] Doc comment long description must start with a
     |       |     capital letter
 116 | ERROR | [x] Expected 1 blank line after function; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...b_posting/src/Plugin/metatag/Tag/SchemaJobPostingJobLocation.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | ERROR | [x] Expected 1 space before opening brace; found 0
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../src/Plugin/metatag/Tag/SchemaJobPostingOccupationalCategory.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | ERROR | [x] Expected 1 space before opening brace; found 0
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...hema_job_posting/src/Plugin/metatag/Tag/SchemaJobPostingType.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 37 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...croot/modules/custom/schema_metatag/src/SchemaMetatagManager.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 174 | ERROR | [x] No space found before comment text; expected "//
     |       |     $value = array_unique($value);" but found
     |       |     "//$value = array_unique($value);"
 368 | ERROR | [ ] Doc comment for parameter $group does not match
     |       |     actual variable name <undefined>
 370 | ERROR | [ ] Superfluous parameter comment
 398 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, question marks, colons, or
     |       |     closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ules/custom/schema_metatag/src/SchemaMetatagManagerInterface.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
  72 | ERROR | Type hint "array" missing for $content
  83 | ERROR | Type hint "array" missing for $item
 105 | ERROR | Type hint "array" missing for $value
 140 | ERROR | Type hint "array" missing for $array
 156 | ERROR | Type hint "array" missing for $array
----------------------------------------------------------------------


FILE: ...ustom/schema_metatag/src/Plugin/metatag/Tag/SchemaActionBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 118 | ERROR | [x] Expected 1 blank line after function; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...stom/schema_metatag/src/Plugin/metatag/Tag/SchemaActionTrait.php
----------------------------------------------------------------------
FOUND 8 ERRORS AND 4 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
 546 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'priceSpecification' => [" but found
     |         |     "//'priceSpecification' => ["
 550 | WARNING | [ ] Line exceeds 80 characters; contains 135
     |         |     characters
 551 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
 552 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'deliveryMethod' => [" but found
     |         |     "//'deliveryMethod' => ["
 556 | WARNING | [ ] Line exceeds 80 characters; contains 87
     |         |     characters
 557 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
 595 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'audience' => [" but found "//'audience' => ["
 599 | WARNING | [ ] Line exceeds 80 characters; contains 99
     |         |     characters
 600 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
 683 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'actionStatus' => [" but found "//'actionStatus'
     |         |     => ["
 687 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 688 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...m/schema_metatag/src/Plugin/metatag/Tag/SchemaSpeakableTrait.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
 59 | ERROR | [ ] No key specified for array entry; first entry
    |       |     specifies key
 60 | ERROR | [x] Array closing indentation error, expected 8 spaces
    |       |     but found 4
 62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     4
 71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     4
 72 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     4
 73 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
    |       |     6
 74 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
    |       |     found 8
 75 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
    |       |     6
 76 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     4
 78 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     4
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...schema_metatag/src/Plugin/metatag/Tag/SchemaCreativeWorkBase.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 85 | ERROR | [x] Expected 1 blank line after function; 0 found
 86 | ERROR | [x] The closing brace for the class must have an empty
    |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...etatag/src/Plugin/metatag/Tag/SchemaItemListElementViewsBase.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 103 | ERROR | Missing parameter type
 106 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------


FILE: ...chema_metatag/src/Plugin/metatag/Tag/SchemaContactPointTrait.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 37 | ERROR | Missing parameter comment
 39 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------


FILE: ...chema_metatag/src/Plugin/metatag/Tag/SchemaCreativeWorkTrait.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 128 | ERROR | [x] There should be no white space after an opening
     |       |     "["
 128 | ERROR | [x] Expected one space after the comma, 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../custom/schema_metatag/src/Plugin/metatag/Tag/SchemaNameBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 243 | ERROR | Type hint "array" missing for $items
----------------------------------------------------------------------


FILE: ...tatag/schema_web_site/src/Plugin/metatag/Group/SchemaWebSite.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 2.98 secs; Memory: 18MB

ERROR: Job failed: exit code 2

Proposed resolution

Apply Drupal coding standards.

Comment	File	Size	Author
#26	3101319-26-code-cleanup.patch	13.17 KB	KarenS
#26	7.x-1.x: PHP 7 & MySQL 5.5, D7.72 57 pass
#24	3101319-24-code-cleanup.patch	13.37 KB	KarenS
#24	7.x-1.x: PHP 7 & MySQL 5.5, D7.72 55 pass, 2 fail
#23	3101319-23-code-cleanup.patch	13.22 KB	KarenS
#23	7.x-1.x: PHP 7 & MySQL 5.5, D7.72 PHPLint Failed
#19	3101319-19-code-cleanup.patch	48.34 KB	KarenS
#19	8.x-1.x: PHP 7.3 & MySQL 5.6, D8.9 57 pass
#17	3101319-17-code-cleanup.patch	46.51 KB	KarenS
#17	8.x-1.x: PHP 7.3 & MySQL 5.6, D8.9 37 pass, 40 fail
#14	3101319-14-code-cleanup.patch	35.96 KB	KarenS
#14	8.x-1.x: PHP 7 & MySQL 5.5, D8.9.1 41 fail PHP 7.3 & MySQL 5.6, D8.9 57 pass PHP 7.2 & MySQL 5.5, D8.9 57 pass PHP 7.1 & MySQL 5.5, D8.9 41 fail
#12	3101319-12-code-cleanup.patch	35.78 KB	KarenS
#12	8.x-1.x: PHP 7 & MySQL 5.5, D8.9.1 41 fail
#8	3101319-8.patch	37.09 KB	vuil
#8	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail PHP 7.1 & MySQL 5.7, D8.8.0 41 fail
#7	3101319-7.patch	36.98 KB	vuil
#7	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail
#6	3101319-6.patch	38.39 KB	vuil
#6	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail
#5	3101319-5.patch	38.13 KB	vuil
#5	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail PHP 7.1 & MySQL 5.7, D8.8.0 41 fail
#4	3101319-4.patch	29.09 KB	vuil
#4	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 54 pass, 6 fail PHP 7.2 & MySQL 5.7, D8.8.0 54 pass, 6 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 December 2019 at 14:30

vuil created an issue. See original summary.

Comment #2

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 16 December 2019 at 14:31

Issue summary:

View changes

Comment #3

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 16 December 2019 at 14:31

Issue summary:

View changes

Comment #4

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 16 December 2019 at 16:02

Status:

Active

» Needs review

File	Size
3101319-4.patch	29.09 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 54 pass, 6 fail PHP 7.2 & MySQL 5.7, D8.8.0 54 pass, 6 fail

Comment #5

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 17 December 2019 at 07:59

File	Size
3101319-5.patch	38.13 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail PHP 7.1 & MySQL 5.7, D8.8.0 41 fail

Comment #6

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 17 December 2019 at 08:51

File	Size
3101319-6.patch	38.39 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail

Comment #7

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 17 December 2019 at 10:29

File	Size
3101319-7.patch	36.98 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail

Comment #8

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 17 December 2019 at 10:40

File	Size
3101319-8.patch	37.09 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.8.0 41 fail PHP 7.1 & MySQL 5.7, D8.8.0 41 fail

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 18 December 2019 at 17:46

You might test it locally first, see if you can resolve the test failures before uploading another patch.

Comment #10

KarenS CreditAttribution: KarenS commented 12 July 2020 at 14:42

Most of the code you're attempting to fix is in Schema Audit, and that module has been deprecated and most of the code removed.

Comment #11

KarenS CreditAttribution: KarenS commented 12 July 2020 at 14:43

When I run this on the current code base I get this report:

FILE: ...hema_job_posting/src/Plugin/metatag/Tag/SchemaJobPostingType.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 37 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...b_posting/src/Plugin/metatag/Tag/SchemaJobPostingJobLocation.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | ERROR | [x] Expected 1 space before opening brace; found 0
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../src/Plugin/metatag/Tag/SchemaJobPostingOccupationalCategory.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | ERROR | [x] Expected 1 space before opening brace; found 0
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...src/Plugin/metatag/Tag/SchemaOrganizationAcceptsReservations.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: ...ugin/metatag/Tag/SchemaOrganizationOpeningHoursSpecification.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | Line exceeds 80 characters; contains 88 characters
----------------------------------------------------------------------


FILE: ...ization/src/Plugin/metatag/Tag/SchemaOrganizationDescription.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 42 | ERROR | [x] Expected 1 blank line after function; 0 found
 43 | ERROR | [x] The closing brace for the class must have an empty
    |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ntrib/schema_metatag/schema_audit/src/Plugin/Block/TestBlock.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  3 | ERROR | [x] Namespaced classes, interfaces and traits should
    |       |     not begin with a file doc comment
 45 | ERROR | [x] Expected 1 space after "=>"; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ntrib/schema_metatag/tests/src/Unit/SchemaMetatagManagerTest.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 106 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
 136 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
 342 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
 364 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     2 spaces
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ib/schema_metatag/tests/src/Functional/SchemaMetatagTagsTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 69 | ERROR | [x] Array closing indentation error, expected 2 spaces
    |       |     but found 3
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...tatag/schema_web_site/src/Plugin/metatag/Group/SchemaWebSite.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...e-demo/web/modules/contrib/schema_metatag/schema_metatag.install
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  94 | ERROR | [x] Doc comment long description must start with a
     |       |     capital letter
 116 | ERROR | [x] Expected 1 blank line after function; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...le-demo/web/modules/contrib/schema_metatag/schema_metatag.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...tatag/schema_movie/src/Plugin/metatag/Tag/SchemaMovieHasPart.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     1
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...les/contrib/schema_metatag/src/SchemaMetatagManagerInterface.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
  72 | ERROR | Type hint "array" missing for $content
  83 | ERROR | Type hint "array" missing for $item
 105 | ERROR | Type hint "array" missing for $value
 140 | ERROR | Type hint "array" missing for $array
 156 | ERROR | Type hint "array" missing for $array
----------------------------------------------------------------------


FILE: ...ntrib/schema_metatag/src/Plugin/metatag/Tag/SchemaActionBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 118 | ERROR | [x] Expected 1 blank line after function; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...etatag/src/Plugin/metatag/Tag/SchemaItemListElementViewsBase.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 103 | ERROR | Missing parameter type
 106 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------


FILE: ...trib/schema_metatag/src/Plugin/metatag/Tag/SchemaActionTrait.php
----------------------------------------------------------------------
FOUND 8 ERRORS AND 4 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
 546 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'priceSpecification' => [" but found
     |         |     "//'priceSpecification' => ["
 550 | WARNING | [ ] Line exceeds 80 characters; contains 135
     |         |     characters
 551 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
 552 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'deliveryMethod' => [" but found
     |         |     "//'deliveryMethod' => ["
 556 | WARNING | [ ] Line exceeds 80 characters; contains 87
     |         |     characters
 557 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
 595 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'audience' => [" but found "//'audience' => ["
 599 | WARNING | [ ] Line exceeds 80 characters; contains 99
     |         |     characters
 600 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
 683 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'actionStatus' => [" but found "//'actionStatus'
     |         |     => ["
 687 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 688 | ERROR   | [x] No space found before comment text; expected "//
     |         |     ]," but found "//],"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...contrib/schema_metatag/src/Plugin/metatag/Tag/SchemaNameBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 243 | ERROR | Type hint "array" missing for $items
----------------------------------------------------------------------


FILE: ...chema_metatag/src/Plugin/metatag/Tag/SchemaContactPointTrait.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 37 | ERROR | Missing parameter comment
 39 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------


FILE: ...chema_metatag/src/Plugin/metatag/Tag/SchemaCreativeWorkTrait.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 128 | ERROR | [x] There should be no white space after an opening
     |       |     "["
 128 | ERROR | [x] Expected one space after the comma, 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...schema_metatag/src/Plugin/metatag/Tag/SchemaCreativeWorkBase.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 85 | ERROR | [x] Expected 1 blank line after function; 0 found
 86 | ERROR | [x] The closing brace for the class must have an empty
    |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../web/modules/contrib/schema_metatag/src/SchemaMetatagManager.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 174 | ERROR | [x] No space found before comment text; expected "//
     |       |     $value = array_unique($value);" but found
     |       |     "//$value = array_unique($value);"
 368 | ERROR | [ ] Doc comment for parameter $group does not match
     |       |     actual variable name <undefined>
 370 | ERROR | [ ] Superfluous parameter comment
 398 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, question marks, colons, or
     |       |     closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Comment #12

KarenS CreditAttribution: KarenS at Lullabot commented 12 July 2020 at 15:57

File	Size
3101319-12-code-cleanup.patch	35.78 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.9.1 41 fail

Something like this.

Comment #13

12 July 2020 at 16:08

Status:

Needs review

» Needs work

The last submitted patch, 12: 3101319-12-code-cleanup.patch, failed testing. View results

Comment #14

KarenS CreditAttribution: KarenS at Lullabot commented 12 July 2020 at 20:29

Status:

Needs work

» Needs review

File	Size
3101319-14-code-cleanup.patch	35.96 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.9.1 41 fail PHP 7.3 & MySQL 5.6, D8.9 57 pass PHP 7.2 & MySQL 5.5, D8.9 57 pass PHP 7.1 & MySQL 5.5, D8.9 41 fail

Comment #15

12 July 2020 at 20:37

Status:

Needs review

» Needs work

The last submitted patch, 14: 3101319-14-code-cleanup.patch, failed testing. View results

Comment #16

KarenS CreditAttribution: KarenS at Lullabot commented 12 July 2020 at 20:41

Hmm, that passed locally. The errors are all "Button with id|name|label|value "Log in" not found", not sure what's going on. Might need to test on PHP 7.3 or later version of MYSQL.

Comment #17

KarenS CreditAttribution: KarenS at Lullabot commented 12 July 2020 at 22:19

Status:

Needs work

» Needs review

File	Size
3101319-17-code-cleanup.patch	46.51 KB
8.x-1.x: PHP 7.3 & MySQL 5.6, D8.9 37 pass, 40 fail

Looks like we now need to indicate a minimum php version of 7.2.

Comment #18

12 July 2020 at 22:26

Status:

Needs review

» Needs work

The last submitted patch, 17: 3101319-17-code-cleanup.patch, failed testing. View results

Comment #19

KarenS CreditAttribution: KarenS at Lullabot commented 12 July 2020 at 22:55

Status:

Needs work

» Needs review

File	Size
3101319-19-code-cleanup.patch	48.34 KB
8.x-1.x: PHP 7.3 & MySQL 5.6, D8.9 57 pass

Comment #20

12 July 2020 at 23:19

KarenS committed 6b8c2bc on 8.x-1.x

Issue #3101319 by vuil, KarenS, DamienMcKenna: PHPCS Errors

Comment #21

KarenS CreditAttribution: KarenS at Lullabot commented 12 July 2020 at 23:19

Status:

Needs review

» Fixed

Committed. Thanks!

Comment #22

KarenS CreditAttribution: KarenS at Lullabot commented 13 July 2020 at 21:34

Version:	8.x-1.x-dev	» 7.x-1.x-dev
Status:	Fixed	» Needs review

Pass some of the common cleanup to D7.

Comment #23

KarenS CreditAttribution: KarenS at Lullabot commented 13 July 2020 at 21:34

File	Size
3101319-23-code-cleanup.patch	13.22 KB
7.x-1.x: PHP 7 & MySQL 5.5, D7.72 PHPLint Failed

Comment #24

KarenS CreditAttribution: KarenS at Lullabot commented 14 July 2020 at 10:40

File	Size
3101319-24-code-cleanup.patch	13.37 KB
7.x-1.x: PHP 7 & MySQL 5.5, D7.72 55 pass, 2 fail

Comment #25

14 July 2020 at 10:43

Status:

Needs review

» Needs work

The last submitted patch, 24: 3101319-24-code-cleanup.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #26

KarenS CreditAttribution: KarenS at Lullabot commented 14 July 2020 at 16:59

Status:

Needs work

» Needs review

File	Size
3101319-26-code-cleanup.patch	13.17 KB
7.x-1.x: PHP 7 & MySQL 5.5, D7.72 57 pass

Comment #27

14 July 2020 at 17:20

KarenS committed f422400 on 7.x-1.x

Issue #3101319 by KarenS, vuil: PHPCS Errors

Comment #28

KarenS CreditAttribution: KarenS at Lullabot commented 14 July 2020 at 17:20

Status:

Needs review

» Fixed

Comment #29

28 July 2020 at 17:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

PHPCS Errors

Problem / Motivation

Proposed resolution

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

Comment #28

Comment #29

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community