Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This module translates strings that are outputted from the Symfony validation constraints objects.
It does so by decorating the Drupal translation manager and adding new behavior that will pick up the Symfony translations.
The user is free to override the Symfony translation as described in the read me file.
Project link
https://www.drupal.org/project/symfony_validator_translator
Git instructions
git clone --branch 8.x-1.x https://git.drupalcode.org/project/symfony_validator_translator.git
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-symfony_valida...
Comments
Comment #2
bonrita CreditAttribution: bonrita commentedComment #3
apadernoThank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.
Comment #4
apadernoCheck the Git settings on the computer used to make commits. Since the commits aren't associated to your Drupal.org account, that email is not one used from your Drupal.org account.
Comment #5
bonrita CreditAttribution: bonrita commentedHi kiamlaluno, indeed the email is from my company and my profile has my personal mail. Let me update my git settings and then push. Thanks again.
Comment #6
bonrita CreditAttribution: bonrita commentedHi kiamlaluno, l have added my company's email address to my Drupal profile. I hope that helps with the commits I committed with the company's email.
Comment #7
apadernoFor those, you need to ask the Drupal.org Infrastructure Team to associate the commits you have done before adding the email to your account.
Comment #8
bonrita CreditAttribution: bonrita commentedHi Kiamlaluno,
the commits have been associated with the new email that I added to the Drupal profile. For more info please see https://www.drupal.org/project/infrastructure/issues/3102310
Comment #9
klausiThanks for you contribution!
Otherwise looks good to me, did not see any security issues.
Comment #10
apadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #11
apadernoComment #12
bonrita CreditAttribution: bonrita commentedHi Klausi, thanks for reviewing the code.
l have updated or fixed all the issues you mentioned.
That is
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-symfony_valida...