Problem/Motivation

The entity.autocomplete_matcher service is handled by EntityAutocompleteMatcher class which doesn't implement any interface. Because of that the EntityAutocompleteController's constructor accepts only instances of that class. That causes problems when trying to decorate the entity.autocomplete_matcher with a class that doesn't extend the original one.

Proposed resolution

Add the EntityAutocompleteMatcherInterface.

Remaining tasks

None.

User interface changes

None.

API changes

EntityAutocompleteMatcherInterface present.

Data model changes

None.

Release notes snippet

EntityAutocompleteMatcherInterface has been added, so the entity.autocomplete_matcher service can be decorated.

CommentFileSizeAuthor
#3 3101516-3.patch5.61 KBblazey
#2 3101516-2.patch5.58 KBblazey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

blazey created an issue. See original summary.

blazey’s picture

blazey CreditAttribution: blazey at Amazee Labs commented
Assigned: blazey » Unassigned
Status: Active » Needs review
FileSize
3101516-2.patch5.58 KB
blazey’s picture

blazey CreditAttribution: blazey at Amazee Labs commented
FileSize
3101516-3.patch5.61 KB
colorfield’s picture

colorfield
Primary language French
Location Lausanne
CreditAttribution: colorfield as a volunteer and at Amazee Labs commented
Status: Needs review » Reviewed & tested by the community

Thank you @blazey, looks good

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3101516-3.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Reviewed & tested by the community

Looks like unrelated test failures so moving it RTBC as per comment #4.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2267926607 to 9.0.x and da4bec840d to 8.9.x. Thanks!

I thought about whether we need a change record for this but I don't think we do.

  • alexpott committed 2267926 on 9.0.x 
    Issue #3101516 by blazey: Add the EntityAutocompleteMatcherInterface

  • alexpott committed da4bec8 on 8.9.x 
    Issue #3101516 by blazey: Add the EntityAutocompleteMatcherInterface

(...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.