Problem/Motivation

Conditional comments are only supported by IE <=9, and any core libraries that make use of them are already removed (see https://www.drupal.org/node/3089508)

Proposed resolution

Remove HtmlTag::preRenderConditionalComments()

Remaining tasks

User interface changes

API changes

The 'browsers' attribute of library assets is ignored.

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 3101620-14.patch29.43 KBlongwave
#12 3101620-12.patch29.76 KBlongwave
#4 drupal-3101620-4.patch21.29 KBgapple
#4 interdiff-3101620-4.txt1.29 KBgapple
#2 drupal-3101620-2.patch19.87 KBgapple
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gapple created an issue. See original summary.

gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Status: Active » Needs review
FileSize
drupal-3101620-2.patch19.87 KB

Status: Needs review » Needs work

The last submitted patch, 2: drupal-3101620-2.patch, failed testing. View results

gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-3101620-4.txt1.29 KB
drupal-3101620-4.patch21.29 KB

Last patch missed use of 'browsers' in CssCollectionGrouper

gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Issue tags: +Deprecation Removal
gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented

One consideration is that if a site has missed or ignored prior warning about 'browsers' being deprecated and not updated to remove any resources that were restricted to IE <= 9, then this change will cause those resources to be output unconditionally for all browsers.
To prevent this, HtmlTag could render an empty string if 'browsers' is set to anything other than ['IE' => TRUE, '!IE' => TRUE] if it exists.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +frontend
gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Title: Remove IE conditional comments support in Drupal 9 » Remove IE conditional comments support in Drupal 10
Version: 9.0.x-dev » 9.1.x-dev
Status: Needs review » Postponed
Parent issue: #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch »

The corresponding deprecation needs to be delayed until 9.1, so removal can't happen till 10.0

gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Version: 9.1.x-dev » 10.0.x-dev
gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Status: Postponed » Needs work
Issue tags: +Drupal 10

Deprecation has been committed to 9.1

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review
FileSize
3101620-12.patch29.76 KB

Rerolled #4 and found a few more bits to clean up.

gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Parent issue: » #3252084: [meta] Remove support for IE11

Setting parent to meta issue

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
FileSize
3101620-14.patch29.43 KB

Rerolled.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Patch looks great - just removals of deprecated code paths.

  • lauriii committed 2307e12 on 10.0.x 
    Issue #3101620 by gapple, longwave, catch: Remove IE conditional...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed 2307e12 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.