Hi
I found a lot of hardlinks in http:// instead of https:// in the metatags *.zip
Wouldn't that be better to made all http:// becoming https:// links ?

find . -name "*.*" -type f -exec sed -i "s/http/https/g" {} \; should make the job, no ?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dbourrion created an issue. See original summary.

DamienMcKenna’s picture

Title: http > https » Change uses of http:// to https://
Version: 7.x-1.26 » 7.x-1.x-dev
Category: Feature request » Task

Thanks for bringing this up. While I don't think an search/replace across the entire codebase would work as there are specific occasions where it does specifically need to work with "http://", it might be a good starting point and we could make some improvements to the patch from there.

dbourrion’s picture

Hi
You're right : I made that brutal search/replace since I suggest it, and it comes to crash my website, for the reasons you suggest ;)

DamienMcKenna’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Active » Needs review
FileSize
22.03 KB

I did a quick check through the D8 codebase and found a number of locations where it'd be fine to replace http:// with https://, so let's see what the testbot says.

DamienMcKenna’s picture

Title: Change uses of http:// to https:// » Change uses of http:// to https:// (D8)
Status: Needs review » Fixed
Parent issue: » #3102475: Plan for Metatag 8.x-1.12

Committed. Thanks for the suggestion! I'll do a separate issue to backport the changes to D7.

  • DamienMcKenna committed 2f20f6c on 8.x-1.x
    Issue #3102582 by DamienMcKenna, dbourrion: Change uses of http:// to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.