Comply with Drupal coding standard (10)

Fix the following coding standard violations:

FILE: /var/www/html/web/modules/contrib/cloud/src/Plugin/views/field/CloudServerTemplateListLink.php
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_budget/src/Entity/CloudCredit.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
   7 | WARNING | [x] Unused use statement
 116 | ERROR   | [x] Missing function doc comment
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_budget/src/Form/CloudBudgetProcessMultipleForm.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
  6 | WARNING | [x] Unused use statement
  7 | WARNING | [x] Unused use statement
  8 | WARNING | [x] Unused use statement
 10 | WARNING | [x] Unused use statement
 11 | WARNING | [x] Unused use statement
 12 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_budget/src/Form/CloudCreditCreateForm.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 6 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_budget/src/Annotation/CloudCostCalculator.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_budget/cloud_budget.module
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------


FILE: ...modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Plugin/cloud_budget/AwsCloudCostCalculator.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...ud_service_providers/aws_cloud/src/Plugin/cloud/server_template/AwsCloudServerTemplatePluginUninstallValidator.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/KeyPair.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 6 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/src/Entity/K8sNodeViewBuilder.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 52 | ERROR | Expected type hint "EntityTypeManager"; found "EntityTypeManagerInterface" for $entity_type_manager
-------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/src/Entity/K8sCronJob.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 7 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------


FILE: ...www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/src/Entity/K8sExportableEntityInterface.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
  6 | WARNING | [x] Unused use statement
 18 | ERROR   | [x] You must use "/**" style comments for a function comment
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/src/Form/Config/K8sAdminSettings.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------
  97 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 127 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/src/Form/K8sDeploymentScaleForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

Comment	File	Size	Author
#6	3102718-6.patch	8.44 KB	yas
#6	8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure
#3	3102718-3.patch	9.51 KB	yas
#3	8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure
#2	3102718-2.patch	9.51 KB	yas
#2	8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 December 2019 at 09:35

yas created an issue. See original summary.

Log in or register to post comments

Comment #2

yas

🇯🇵 he/him

Japanese

California 🇺🇸

CreditAttribution: yas at DOCOMO Innovations, Inc. commented 23 December 2019 at 09:43

Status:

Needs work

» Needs review

File	Size
3102718-2.patch	9.51 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure

@all

Please review the patch.

Log in or register to post comments

Comment #3

yas

🇯🇵 he/him

Japanese

California 🇺🇸

CreditAttribution: yas at DOCOMO Innovations, Inc. commented 23 December 2019 at 21:59

File	Size
3102718-3.patch	9.51 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure

1 file was hidden/shown/deleted

File	Size
3102718-2.patch	9.51 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure

Log in or register to post comments

baldwinlouie’s picture

Comment #4

baldwinlouie CreditAttribution: baldwinlouie commented 26 December 2019 at 02:36

Status:

Needs review

» Reviewed & tested by the community

@yas, this looks good.

Log in or register to post comments

Comment #5

yas

🇯🇵 he/him

Japanese

California 🇺🇸

CreditAttribution: yas at DOCOMO Innovations, Inc. commented 27 December 2019 at 03:12

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

Log in or register to post comments

Comment #6

yas

🇯🇵 he/him

Japanese

California 🇺🇸

CreditAttribution: yas at DOCOMO Innovations, Inc. commented 27 December 2019 at 03:26

File	Size
3102718-6.patch	8.44 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure

1 file was hidden/shown/deleted

File	Size
3102718-3.patch	9.51 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.8.1 Composer require failure

Updating the patch

Log in or register to post comments

Comment #7

27 December 2019 at 03:34

yas committed d0d7886 on 8.x-2.x

Issue #3102718 by yas, baldwinlouie: Comply with Drupal coding standard...

Log in or register to post comments

Comment #8

yas

🇯🇵 he/him

Japanese

California 🇺🇸

CreditAttribution: yas at DOCOMO Innovations, Inc. commented 27 December 2019 at 03:34

Status:

Reviewed & tested by the community

» Fixed

Log in or register to post comments

Comment #9

10 January 2020 at 03:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments