This module extend the theme permissions and allows specific roles to edit the theme.

Project link

https://www.drupal.org/project/theme_permission

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/theme_permission.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-theme_permissi...

Comments

liber_t created an issue. See original summary.

apaderno’s picture

Issue summary: View changes

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

klausi’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for you contribution!

  1. dynamicPermissions(): The machine name of permissions should be all lower case to be consistent with other Drupal permissions. "Edit Administration theme" has a couple of upper case characters in it.
  2. RouteSubscriber: shouldn't you unset the old permission requirement on all those routes? Probably this works by accident now. Or do all the roles need the "administer themes" permission in addition?

Otherwise looks good to me, did not see any security issues.

apaderno’s picture

Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.