Problem/Motivation

The file_unmanaged_delete function was deprecated

Proposed resolution

Replace deprecated file_unmanaged_delete function

CommentFileSizeAuthor
#4 3104227-4.patch8.26 KBjrockowitz
#2 webform-Replace_deprecated_file_unmanaged_delete_function-3104227-2-D8.patch8.3 KBthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
webform-Replace_deprecated_file_unmanaged_delete_function-3104227-2-D8.patch8.3 KB

Follow a new patch.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Needs work

Changing the constructor's arguments is going to break any module that extends this code. Any new dependencies need to be added last and support a NULL default value.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Needs review
FileSize
3104227-4.patch8.26 KB
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Ok, all right!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

  • jrockowitz authored 761db80 on 8.x-5.x 
    Issue #3104227 by thalles, jrockowitz: Replace deprecated...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.