This module should declare its minimum supported version of core using core_version_requirement, to properly prepare for Drupal 9.

CommentFileSizeAuthor
#6 3104897-6.patch851 bytesphenaproxima
#2 3104897-2.patch677 bytesphenaproxima
#4 3104897-4.patch746 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
3104897-2.patch677 bytes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented 
  1. +++ b/composer.json
@@ -0,0 +1,6 @@
+{
+    "require": {
+        "drupal/core": "^8.7.7 || ^9"
+    }
+}

    huh, didn't know that was possible, so far I've always added the basic keys name + description + type 

  2. +++ b/contact_storage.info.yml
@@ -1,9 +1,9 @@
 dependencies:
-  - drupal:contact (>=8.6)
+  - drupal:contact (>=8.7)
   - drupal:views

    I think you can remove the version here, so we don't have to update two places in the future?

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
3104897-4.patch746 bytes

Good points both. How does this look?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/composer.json
@@ -0,0 +1,5 @@
+    "name": "Contact storage",

that's not how the name works :)

Also you lost the require key.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
3104897-6.patch851 bytes

that's not how the name works :)

I, er, totally knew that. Yup, for sure. I was just...testing you. Yes, that's the excuse I'm going to use.

Here's a real patch that should actually work.

  • Berdir committed 8c3caea on 8.x-1.x authored by phenaproxima 
    Issue #3104897 by phenaproxima, Berdir: Declare core_version_requirement
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Also updated the test module, cleaned up its dependencies and updated #3081195-8: Update code deprecated in 8.8 with the remaining 8.8 deprecations to take care of next.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.