On the metatag admin page, the following message is shown at all times.

Please note that while the site is in maintenance mode none of the usual meta tags will be output.

Should this only be shown when the site is in maintenance mode?

Also, these messages are shown using the depreciated drupal_set_message function.
(Can be replaced with \Drupal::messenger()->addMessage)

CommentFileSizeAuthor
#2 metatag-3105343-2.patch1.54 KBKionn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kionn created an issue. See original summary.

Kionn’s picture

Kionn CreditAttribution: Kionn as a volunteer commented
FileSize
metatag-3105343-2.patch1.54 KB

Here is a patch that checks if the site is in maintenance mode, and also updates the depreciated functions.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Agiledrop - Your Trusted Drupal Teammates commented
Status: Active » Reviewed & tested by the community

Hello,
Thanks for the patch. I was about to upload my own patch when I noticed the issue was updated. So instead of uploading mine I reviewed yours. The patch works as expected.

Thanks and kind regards, Denis

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3102475: Plan for Metatag 8.x-1.12
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Maintenance mode message shown when site is not in maintenance mode. » Maintenance mode message shown on settings forms when site is not in maintenance mode.

  • DamienMcKenna committed e1a287a on 8.x-1.x authored by Kionn 
    Issue #3105343 by Kionn, DenisCi: Maintenance mode message shown on...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.