CommentFileSizeAuthor
#2 3105976-2.patch771 bytesHardik_Patel_12
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Hardik_Patel_12 created an issue. See original summary.

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commented
FileSize
3105976-2.patch771 bytes

Kindly review a new patch.

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commented
Assigned: Hardik_Patel_12 » Unassigned
Status: Needs work » Needs review
snehalgaikwad’s picture

snehalgaikwad CreditAttribution: snehalgaikwad at QED42 commented
Status: Needs review » Reviewed & tested by the community

I've tried this patch, working fine.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs change record

This should be fine to commit in a minor release, since no-one should be calling this indirectly. However I think it could use a just-in-case change record documenting that we now require the type-hint.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Version: 9.0.x-dev » 9.1.x-dev
Issue tags: -Needs change record

I added a change record. I've never added one before so update it if it needs adjusting.

https://www.drupal.org/node/3158723

Patch still applies to 9.1.x but I have kicked off tests since they were run on 9.0.x.

If the tests come back green, this looks RTBC to me.

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commented

I have retested the patch and it's again green. So it's looks good to move.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Thanks but I'm unclear why you ran the tests a second time.

Anyway, all green so RTBC. :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed af4c993 and pushed to 9.1.x. Thanks!

  • alexpott committed af4c993 on 9.1.x 
    Issue #3105976 by Hardik_Patel_12, Kristen Pol, catch: Type hint "\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.