Problem/Motivation

We need to add D9 support into this module. Depends on #3090902: Update info.yml to support D9

Proposed resolution

1. Add core_version_requirement: ^8 || ^9 to info.yml file
2. Fix deprecations

CommentFileSizeAuthor
#11 performance_budget-3106206-d9-support-7.patch2.37 KBWidgetsBurritos
#7 interdiff-6-7.txt332 bytesWidgetsBurritos
#7 performance_budget-3106206-d9-support-7.patch2.37 KBWidgetsBurritos
#6 performance_budget-3106206-d9-support-6.patch2.38 KBWidgetsBurritos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

WidgetsBurritos created an issue. See original summary.

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented
Issue tags: +Drupal 9 compatibility
WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented
Status: Active » Postponed

Depends on #3090902: Update info.yml to support D9

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented

I went ahead and updated the info.yml file so we can start setting up D9 testing on here.

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented
Status: Postponed » Needs review
FileSize
performance_budget-3106206-d9-support-6.patch2.38 KB

Okay, now that #3090902: Update info.yml to support D9 is completed, this patch should get the performance budget module to be D9 compatible. This does require WPA 2.13+ though.

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented
FileSize
performance_budget-3106206-d9-support-7.patch2.37 KB
interdiff-6-7.txt332 bytes

I'm hoping this change fixes the weird composer build error. It actually makes me wonder how it ever built in the first place. ¯\_(ツ)_/¯

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented

Hmmm. The builds are successful but nightwatch is failing for some reason. It appears it's happening on the main branch so I'm assuming it's unrelated. Will need to dig into that a bit further.

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented
Issue tags: +ContributionWeekend2020

I'd like to resolve this over ContributionWeekend2020

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented

Nightwatch issues were resolved in #3110528: Failing nightwatch tests. Rerunning tests again.

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented
FileSize
performance_budget-3106206-d9-support-7.patch2.37 KB

Same patch as before

WidgetsBurritos’s picture

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.