Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Review of the 8.x-1.x branch (commit 7193bc5):
Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script.
FILE: ...upal/pareviewsh/pareview_temp/tests/src/Functional/WithOtlLogout.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
6 | WARNING | [x] Unused use statement
34 | ERROR | [ ] Public method name "WithOtlLogout::testOTL" is not in
| | lowerCamel format
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...l/pareviewsh/pareview_temp/tests/src/Functional/WithoutOtlLogout.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
40 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing parentheses
73 | ERROR | [ ] Public method name "WithoutOtlLogout::testOTL" is not
| | in lowerCamel format
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Time: 622ms; Memory: 4Mb
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3107712-11.patch | 3.41 KB | Suresh Prabhu Parkala |
| #2 | issue_fix-3107712-2.patch | 2.35 KB | Ankush_03 |
Comments
Comment #2
Ankush_03Attached Patch for the same.
Comment #3
Ankush_03PHP 5.5 & MySQL 5.5, D8.8.1 Composer config failure
For the above issue please create composer.json file for the same.
Comment #4
Ankush_03Comment #5
Ankush_03Comment #6
DamienMcKennaThe proposed changes to README.txt make the file messier than it already is, with redundant headings, unnecessary indentation, etc.
The proposed change to WithoutOtlLogout::$modules isn't correct as second commented line is commented out PHP code, not just English text, as such it should be left as valid PHP code; if anything the line could be wrapped with
@codeand@endcode.Comment #7
abhijeet.kumar2107 CreditAttribution: abhijeet.kumar2107 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #8
pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commentedComment #9
pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commentedComment #10
WebbehComment #11
Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commentedPlease review the patch.
Comment #13
DamienMcKennaCommitted. Well, part of it. Thank you.