Let's get Claro added as a dependency to stop people seeing an odd result :)

CommentFileSizeAuthor
#10 add-claro-dependency-3107825-#10.patch725 bytesmalte.koelle
#9 add-claro-dependency-3107825-#9.patch735 bytesmalte.koelle
#3 3107825-0.patch292 bytesChandeepKhosa
#2 add-claro-as-a-dependency-3107825-0.patch292 bytesChandeepKhosa
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ChandeepKhosa created an issue. See original summary.

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
FileSize
add-claro-as-a-dependency-3107825-0.patch292 bytes

Here's the patch

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Status: Active » Needs review
FileSize
3107825-0.patch292 bytes

Renamed patch file & queuing this for review

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Status: Needs review » Postponed (maintainer needs more info)

@ChandeepKhosa does this work for you on D8.8? I'm just getting an error
Unable to install modules: module 'gin_login' is missing its dependency module claro.
But as claro is not a module but rather a theme I'm not sure if we can solve that this way.

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented

Sorry I was lazy and didn't test it, no it doesn't work for me either. I tried googling but didn't find a solution on doing this.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Status: Postponed (maintainer needs more info) » Postponed

I've created a core issue for this #3108003: Dependency on (core) themes (e.g. Claro)

jkswoods’s picture

jkswoods CreditAttribution: jkswoods at interactive investor commented
Status: Postponed » Active

This doesn't necessarily have to rely on waiting for the ability to define dependency on themes. A solution for this can be to have a check in hook_requirements that occurs during the 'install' phase. After evaluating that the claro theme is not enabled, return a REQUIREMENT_ERROR.

See: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at Unic commented

@jkswoods can you provide a patch for this? :)

malte.koelle’s picture

malte.koelle CreditAttribution: malte.koelle as a volunteer commented
Status: Active » Needs review
FileSize
add-claro-dependency-3107825-#9.patch735 bytes
malte.koelle’s picture

malte.koelle CreditAttribution: malte.koelle as a volunteer commented
FileSize
add-claro-dependency-3107825-#10.patch725 bytes

I added a hook_requirements, which checks if claro is installed.
#9 had a typo. Now it looks better.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at Unic commented

This needs another round of community testing. Thanks in advance!

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at Unic commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.