Problem/Motivation

Discover if there are any problems when migrating to Drupal 9.

Proposed resolution

Running drupal-check against commit 95f167d gives:

./vendor/bin/drupal-check modules/contrib/recreate_block_content/
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   recreate_block_content.module                      
 ------ --------------------------------------------------- 
  54     Call to deprecated function drupal_set_message().  
  56     Call to deprecated function drush_log().           
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors

Remaining tasks

Remove deprecated code.

CommentFileSizeAuthor
#10 interdiff04-10.txt413 bytesedycarreyes99
#10 3109039-10.patch413 bytesedycarreyes99
#4 3109039-4.patch696 bytesAnkush_03
#3 3109039-3.patch695 bytesAnkush_03
#2 3109039-2.patch569 bytesJohn Cook
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

John Cook created an issue. See original summary.

John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Active » Needs review
Issue tags: +ContributionWeekend2020
FileSize
3109039-2.patch569 bytes

I've uploaded a patch to replace the call to drupal_set_message().

But I'm unsure how to replace drush_log().

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3109039-3.patch695 bytes

Added updated patch !

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3109039-4.patch696 bytes
Joao Sausen’s picture

Joao Sausen CreditAttribution: Joao Sausen as a volunteer commented

Thanks, I will be merging this on the next release.

  • Joao Sausen committed f541e51 on 8.x-2.x 
    Issue #3109039 by john@johncook.me.uk,ankushgautam76@gmail.com: Drupal 9...
Joao Sausen’s picture

Joao Sausen CreditAttribution: Joao Sausen as a volunteer commented

This is merged on 8.x-2.x-dev

Joao Sausen’s picture

Joao Sausen CreditAttribution: Joao Sausen as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

edycarreyes99’s picture

edycarreyes99 CreditAttribution: edycarreyes99 at MTech, LLC commented
Assigned: Unassigned » edycarreyes99
FileSize
3109039-10.patch413 bytes
interdiff04-10.txt413 bytes

added core_version_requirement to the module.info.yml file