CommentFileSizeAuthor
#7 interdiff.txt1.19 KBdeepakkumar14
#7 external-redirect-3109793-7.patch5.01 KBdeepakkumar14
#5 Screenshot from 2020-08-19 12-30-52.png3.83 KBlisotton
#4 interdiff_3-4.txt693 bytesdeepakkumar14
#4 external-redirect-3109793-4.patch5.03 KBdeepakkumar14
#3 interdiff_2-3.txt5.35 KBlisotton
#3 external-redirect-3109793-3.patch4.28 KBlisotton
#2 3109793-2.patch4.15 KBdeepakkumar14
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

purushotam.rai created an issue. See original summary.

deepakkumar14’s picture

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Active » Needs review
FileSize
3109793-2.patch4.15 KB

I have created a patch for redirect user to external URL after logout.

lisotton’s picture

lisotton CreditAttribution: lisotton at CI&T commented
FileSize
external-redirect-3109793-3.patch4.28 KB
interdiff_2-3.txt5.35 KB

Hi @deepakkumar14,
I have changed a bit your patch to fix some Code Standards, can you please review?

deepakkumar14’s picture

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
external-redirect-3109793-4.patch5.03 KB
interdiff_3-4.txt693 bytes

Hi, @lisotton Thank you for checking the coding standard and review my patch. I have tested your patch but i found one issue and i have changed it in .module file
$this->messenger->addMessage(Xss::filter($token_service->replace($logout_message)));
to
\Drupal::messenger()->addMessage(Xss::filter($token_service->replace($logout_message)));
And its working fine for me. Please review.

lisotton’s picture

lisotton CreditAttribution: lisotton at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot from 2020-08-19 12-30-52.png3.83 KB

I confirm that it is working, I can see the message after logout:
test message

Prashant.c’s picture

Prashant.c
he/him
Primary language English
Location Dharamshala
CreditAttribution: Prashant.c as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Reviewed & tested by the community » Needs work

The patch #4 has some issues, the moment I am applying this my site throws The website encountered an unexpected error. Please try again later..

Drupal Version - 8.9.x
Module Version - 8.x-1.x

Please test with these versions.

deepakkumar14’s picture

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
external-redirect-3109793-7.patch5.01 KB
interdiff.txt1.19 KB

I have added new patch for this.

Prashant.c’s picture

Prashant.c
he/him
Primary language English
Location Dharamshala
CreditAttribution: Prashant.c as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Fixed

Fixed. Thanks to the contributors.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.