Remove the code deprecated in Drupal 9 [#3110970]

drupal-check elasticsearch_connector/ -ad
------ --------------------------------------------------------------------------------------------
  Line   elasticsearch_connector.module
 ------ --------------------------------------------------------------------------------------------
  90     Function form_process_select not found.
  95     Function elasticsearch_cluster_load_all not found.
  133    Function module_implements not found.
  164    Function module_implements not found.
  180    Function elasticsearch_connector_get_default not found.
  227    Function current_path not found.
  233    Function elasticsearch_cluster_load_all not found.
  243    Function elasticsearch_get_indices_options not found.
  276    Function theme not found.
  291    Function drupal_alter not found.
  300    Function elasticsearch_in_dialog not found.
  352    Function elasticsearch_in_dialog not found.
  353    Function drupal_add_js not found.
  354    Function drupal_add_js not found.
  385    Function drupal_array_get_nested_value not found.
  403    Function elasticsearch_get_client_by_id not found.
  406    Function drupal_alter not found.
  433    Function elasticsearch_connector_index_valid_load() should return bool but returns string.
  513    Function theme not found.
  529    Function form_error not found.
 ------ --------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/elasticsearch_connector_views/src/Plugin/views/ElasticsearchViewsHandlerTrait.php (in context of class Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField)
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  47     Method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::getIndex() should return string but returns null.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/elasticsearch_connector_views/src/Plugin/views/field/ElasticsearchViewsEntity.php
 ------ ------------------------------------------------------------------------------------------------------------------------------------------
  86     Call to deprecated method getEntityManager() of class Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal\views\FieldAPIHandlerTrait::getEntityFieldManager() instead.
  171    Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity::addRetrievedProperty().
  171    Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity::getCombinedPropertyPath().
  182    Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity::getCombinedPropertyPath().
  197    Call to deprecated method getEntityManager() of class Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal\views\FieldAPIHandlerTrait::getEntityFieldManager() instead.
  200    Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity::getQuery().
  217    Call to an undefined static method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsStandard::render_item().
  224    Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity::getCombinedPropertyPath().
  275    Call to deprecated method getEntityManager() of class Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntity:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal\views\FieldAPIHandlerTrait::getEntityFieldManager() instead.
 ------ ------------------------------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/elasticsearch_connector_views/src/Plugin/views/field/ElasticsearchViewsEntityField.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------
  47     Property Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::$fallbackHandler
         (Drupal\views\Plugin\views\field\FieldHandlerInterface) does not accept Drupal\views\Plugin\views\ViewsHandlerInterface.
  71     Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::getDatasourceId().
  71     Call to static method createCombinedId() on an unknown class Drupal\elasticsearch_connector_views\Plugin\views\field\Utility.
  72     Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::addRetrievedProperty().
  83     Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::getCombinedPropertyPath().
  84     Call to static method splitCombinedId() on an unknown class Drupal\elasticsearch_connector_views\Plugin\views\field\Utility.
  85     Call to static method splitPropertyPath() on an unknown class Drupal\elasticsearch_connector_views\Plugin\views\field\Utility.
  99     Call to an undefined method Drupal\views\Plugin\views\field\FieldHandlerInterface::defineOptions().
  220    Call to method compatibleWithField() on an unknown class Drupal\elasticsearch_connector_views\Plugin\views\field\EntityFieldRenderer.
  220    Class Drupal\elasticsearch_connector_views\Plugin\views\field\EntityFieldRenderer not found.
  221    Property Drupal\views\Plugin\views\field\EntityField::$entityFieldRenderer (Drupal\views\Entity\Render\EntityFieldRenderer) does not accept
         Drupal\elasticsearch_connector_views\Plugin\views\field\EntityFieldRenderer.
  228    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::$entityManager.
  229    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::$entityManager.
  229    Instantiated class Drupal\elasticsearch_connector_views\Plugin\views\field\EntityFieldRenderer not found.
  229    Property Drupal\views\Plugin\views\field\EntityField::$entityFieldRenderer (Drupal\views\Entity\Render\EntityFieldRenderer) does not accept
         Drupal\elasticsearch_connector_views\Plugin\views\field\EntityFieldRenderer.
  230    Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\field\ElasticsearchViewsEntityField::getDatasourceId().
  230    Call to method setDatasourceId() on an unknown class Drupal\elasticsearch_connector_views\Plugin\views\field\EntityFieldRenderer.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------
  Line   modules/elasticsearch_connector_views/src/Plugin/views/filter/ElasticsearchViewsFulltextSearch.php
 ------ ----------------------------------------------------------------------------------------------------
  28     Access to an undefined property Drupal\views\Plugin\views\query\QueryPluginBase::$where.
  133    Variable $identifier might not be defined.
  134    Variable $identifier might not be defined.
  142    Variable $source might not be defined.
 ------ ----------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------
  Line   modules/elasticsearch_connector_views/src/Plugin/views/filter/ElasticsearchViewsStringFilter.php
 ------ --------------------------------------------------------------------------------------------------
  50     Variable $identifier might not be defined.
  51     Variable $identifier might not be defined.
  59     Variable $source might not be defined.
  195    Access to an undefined property Drupal\views\Plugin\views\query\QueryPluginBase::$where.
 ------ --------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/elasticsearch_connector_views/src/Plugin/views/query/ElasticsearchViewsQuery.php
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------
  178    Property Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$elasticsearchCluster
         (Drupal\elasticsearch_connector\Entity\Cluster) does not accept Drupal\Core\Entity\EntityInterface|null.
  197    PHPDoc tag @param has invalid value ($field
         Field name.): Unexpected token "$field", expected type at offset 54
  197    PHPDoc tag @param has invalid value ($table
         Table name.): Unexpected token "$table", expected type at offset 16
  198    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$fields.
  219    PHPDoc tag @param for parameter $join with type Drupal\views\Plugin\views\join\JoinPluginBase is not subtype of native type
         Drupal\elasticsearch_connector_views\Plugin\views\query\JoinPluginBase|null.
  219    PHPDoc tag @param has invalid value ($relationship
         The relationship to ensure the table links to. Each relationship will
         get a unique instance of the table being added. If not specified,
         will be the primary table.): Unexpected token "$relationship", expected type at offset 294
  219    PHPDoc tag @param has invalid value ($table
         The not aliased name of the table to ensure.): Unexpected token "$table", expected type at offset 223
  219    PHPDoc tag @return has invalid value (): Unexpected token "\n   *", expected type at offset 637
  219    Parameter $join of method Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::ensureTable() has invalid typehint type
         Drupal\elasticsearch_connector_views\Plugin\views\query\JoinPluginBase.
  254    Call to an undefined method Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::getEntityTypes().
  292    Parameter $view of method Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::build() has invalid typehint type
         Drupal\views\Plugin\views\query\view.
  313    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$params.
  336    Access to an undefined property $this(Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery)::$where.
  353    Access to an undefined property $this(Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery)::$query_params.
  365    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$sort_fields.
  390    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$group_operator.
  399    Parameter $view of method Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::alter() has invalid typehint type
         Drupal\views\Plugin\views\query\view.
  411    Parameter $view of method Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::execute() has invalid typehint type
         Drupal\views\Plugin\views\query\view.
  414    Access to an undefined property Drupal\views\ViewExecutable::$execute_time.
  421    If condition is always true.
  429    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$query_params.
  520    Method Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::getAccessAccount() should return
         Drupal\Core\Session\AccountInterface|null but returns false.
  531    Access to an undefined property Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$query.
  575    PHPDoc tag @param has invalid value ($table): Unexpected token "$table", expected type at offset 44
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   src/ClusterManager.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------
  18     Property Drupal\elasticsearch_connector\ClusterManager::$state has unknown class Drupal\Node\NodeStorageInterface as its type.
  34     Property Drupal\elasticsearch_connector\ClusterManager::$state (Drupal\Node\NodeStorageInterface) does not accept Drupal\Core\State\StateInterface.
  45     Call to method get() on an unknown class Drupal\Node\NodeStorageInterface.
  56     Call to method set() on an unknown class Drupal\Node\NodeStorageInterface.
  72     Access to an undefined property Drupal\Core\Entity\EntityInterface::$status.
  73     Access to an undefined property Drupal\Core\Entity\EntityInterface::$cluster_id.
  77     Method Drupal\elasticsearch_connector\ClusterManager::loadAllClusters() should return array<Drupal\elasticsearch_connector\Entity\Cluster> but returns
         array<Drupal\Core\Entity\EntityInterface>.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------
  Line   src/Controller/ClusterListBuilder.php
 ------ --------------------------------------------------------------------------------
  66     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
  150    Call to an undefined method nodespark\DESConnector\ClientInterface::cluster().
  174    Access to an undefined property Drupal\Core\Entity\EntityInterface::$status.
 ------ --------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------
  Line   src/Controller/ElasticsearchController.php
 ------ ------------------------------------------------------------------------------------------------
  36     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
  60     Method Drupal\Core\Form\FormBuilderInterface::getForm() invoked with 2 parameters, 1 required.
 ------ ------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------
  Line   src/ElasticSearch/Parameters/Builder/SearchBuilder.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------
  59     Property Drupal\elasticsearch_connector\ElasticSearch\Parameters\Builder\SearchBuilder::$index (Drupal\search_api\Entity\Index) does not accept
         Drupal\search_api\IndexInterface.
  204    Call to an undefined method Drupal\search_api\Backend\BackendInterface::getFuzziness().
  312    Call to an undefined method Drupal\elasticsearch_connector\ElasticSearch\Parameters\Builder\SearchBuilder::luceneFlattenKeys().
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------
  Line   src/ElasticSearch/Parameters/Factory/IndexFactory.php
 ------ --------------------------------------------------------------------------------------------------------------------
  184    Class Drupal\search_api_autocomplete\Suggester\SuggesterInterface not found.
  185    Call to method getConfiguration() on an unknown class Drupal\search_api_autocomplete\Suggester\SuggesterInterface.
  188    Call to method getSearch() on an unknown class Drupal\search_api_autocomplete\Suggester\SuggesterInterface.
  233    Call to function is_string() with Drupal\search_api\IndexInterface will always evaluate to false.
  236    Call to an undefined method Drupal\search_api\Backend\BackendInterface::getCluster().
 ------ --------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------
  Line   src/Event/BuildIndexParamsEvent.php
 ------ --------------------------------------------------------------------------------------------------------------------------------
  25     PHPDoc tag @param has invalid value ($indexName): Unexpected token "$indexName", expected type at offset 81
  25     PHPDoc tag @param has invalid value ($params): Unexpected token "$params", expected type at offset 61
  35     Return typehint of method Drupal\elasticsearch_connector\Event\BuildIndexParamsEvent::getElasticIndexParams() has invalid type
         Drupal\elasticsearch_connector\Event\params.
  44     PHPDoc tag @param has invalid value ($params): Unexpected token "$params", expected type at offset 62
  53     Return typehint of method Drupal\elasticsearch_connector\Event\BuildIndexParamsEvent::getIndexName() has invalid type
         Drupal\elasticsearch_connector\Event\indexName.
 ------ --------------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------------------
  Line   src/Event/BuildSearchParamsEvent.php
 ------ ----------------------------------------------------------------------------------------------------------------------------------
  25     PHPDoc tag @param has invalid value ($indexName): Unexpected token "$indexName", expected type at offset 82
  25     PHPDoc tag @param has invalid value ($params): Unexpected token "$params", expected type at offset 62
  35     Return typehint of method Drupal\elasticsearch_connector\Event\BuildSearchParamsEvent::getElasticSearchParams() has invalid type
         Drupal\elasticsearch_connector\Event\params.
  44     PHPDoc tag @param has invalid value ($params): Unexpected token "$params", expected type at offset 62
  53     Return typehint of method Drupal\elasticsearch_connector\Event\BuildSearchParamsEvent::getIndexName() has invalid type
         Drupal\elasticsearch_connector\Event\indexName.
 ------ ----------------------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------
  Line   src/Event/PrepareIndexEvent.php
 ------ ---------------------------------------------------------------------------------------------------------------------
  25     PHPDoc tag @param has invalid value ($indexConfig): Unexpected token "$indexConfig", expected type at offset 57
  25     PHPDoc tag @param has invalid value ($indexName): Unexpected token "$indexName", expected type at offset 82
  35     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareIndexEvent::getIndexConfig() has invalid type
         Drupal\elasticsearch_connector\Event\indexConfig.
  44     PHPDoc tag @param has invalid value ($indexConfig): Unexpected token "$indexConfig", expected type at offset 61
  53     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareIndexEvent::getIndexName() has invalid type
         Drupal\elasticsearch_connector\Event\indexName.
 ------ ---------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------
  Line   src/Event/PrepareIndexMappingEvent.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------
  25     PHPDoc tag @param has invalid value ($indexMappingParams): Unexpected token "$indexMappingParams", expected type at offset 64
  25     PHPDoc tag @param has invalid value ($indexName): Unexpected token "$indexName", expected type at offset 96
  35     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareIndexMappingEvent::getIndexMappingParams() has invalid type
         Drupal\elasticsearch_connector\Event\indexMappingParams.
  44     PHPDoc tag @param has invalid value ($indexMappingParams): Unexpected token "$indexMappingParams", expected type at offset 61
  53     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareIndexMappingEvent::getIndexName() has invalid type
         Drupal\elasticsearch_connector\Event\indexName.
 ------ -----------------------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------
  Line   src/Event/PrepareMappingEvent.php
 ------ -------------------------------------------------------------------------------------------------------------------------
  27     PHPDoc tag @param has invalid value ($field): Unexpected token "$field", expected type at offset 104
  27     PHPDoc tag @param has invalid value ($mappingConfig): Unexpected token "$mappingConfig", expected type at offset 59
  27     PHPDoc tag @param has invalid value ($type): Unexpected token "$type", expected type at offset 86
  38     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareMappingEvent::getMappingConfig() has invalid type
         Drupal\elasticsearch_connector\Event\mappingConfig.
  47     PHPDoc tag @param has invalid value ($mappingConfig): Unexpected token "$mappingConfig", expected type at offset 63
  56     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareMappingEvent::getMappingType() has invalid type
         Drupal\elasticsearch_connector\Event\type.
  65     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareMappingEvent::getMappingField() has invalid type
         Drupal\elasticsearch_connector\Event\field.
 ------ -------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------------------
  Line   src/Event/PrepareSearchQueryEvent.php
 ------ ----------------------------------------------------------------------------------------------------------------------------------
  25     PHPDoc tag @param has invalid value ($elasticSearchQuery): Unexpected token "$elasticSearchQuery", expected type at offset 63
  25     PHPDoc tag @param has invalid value ($indexName): Unexpected token "$indexName", expected type at offset 95
  35     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareSearchQueryEvent::getElasticSearchQuery() has invalid type
         Drupal\elasticsearch_connector\Event\elasticSearchQuery.
  44     PHPDoc tag @param has invalid value ($elasticSearchQuery): Unexpected token "$elasticSearchQuery", expected type at offset 74
  53     Return typehint of method Drupal\elasticsearch_connector\Event\PrepareSearchQueryEvent::getIndexName() has invalid type
         Drupal\elasticsearch_connector\Event\indexName.
 ------ ----------------------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------
  Line   src/Form/ClusterDeleteForm.php
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------
  51     PHPDoc tag @param for parameter $entity_manager with type Drupal\Core\Entity\EntityManager|Drupal\Core\Entity\EntityTypeManager is not subtype of
         native type Drupal\Core\Entity\EntityTypeManager.
  56     Property Drupal\elasticsearch_connector\Form\ClusterDeleteForm::$entityManager (Drupal\Core\Entity\EntityManager) does not accept
         Drupal\Core\Entity\EntityTypeManager.
  65     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
  97     Access to an undefined property Drupal\Core\Entity\EntityInterface::$cluster_id.
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------
  Line   src/Form/ClusterForm.php
 ------ -------------------------------------------------------------------------------------------------------------------
  47     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
  152    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  174    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  188    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  201    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  214    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  231    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  243    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  250    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  265    Access to an undefined property Drupal\Core\Entity\EntityInterface::$options.
  386    Method Drupal\elasticsearch_connector\Form\ClusterForm::save() should return int but return statement is missing.
 ------ -------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------
  Line   src/Form/IndexDeleteForm.php
 ------ --------------------------------------------------------------------------------
  48     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
  67     Access to an undefined property Drupal\Core\Entity\EntityInterface::$server.
  71     Access to an undefined property Drupal\Core\Entity\EntityInterface::$index_id.
  73     Access to an undefined property Drupal\Core\Entity\EntityInterface::$index_id.
 ------ --------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------------------
  Line   src/Form/IndexForm.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------
  49     Property Drupal\elasticsearch_connector\Form\IndexForm::$entityTypeManager (Drupal\Core\Entity\EntityTypeManager) does not accept
         Drupal\Core\Entity\EntityTypeManagerInterface.
  60     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
  74     Method Drupal\elasticsearch_connector\Form\IndexForm::getEntityManager() should return Drupal\Core\Entity\EntityManager but returns
         Drupal\Core\Entity\EntityTypeManager.
  109    Access to an undefined property Drupal\Core\Entity\EntityInterface::$cluster_id.
  272    Access to an undefined property Drupal\Core\Entity\EntityInterface::$server.
  275    Access to an undefined property Drupal\Core\Entity\EntityInterface::$index_id.
  280    Method Drupal\elasticsearch_connector\Form\IndexForm::save() should return int but return statement is missing.
 ------ -------------------------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   src/Plugin/search_api/backend/SearchApiElasticsearchBackend.php
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------
  201    Property Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::$cluster
         (Drupal\elasticsearch_connector\Entity\Cluster) does not accept Drupal\Core\Entity\EntityInterface|null.
  219    Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
  295    Binary operation "+=" between array('' => Drupal\Core\StringTranslation\TranslatableMarkup, 'auto' => 'auto') and array|false results in an error.
  475    Call to an undefined method nodespark\DESConnector\ClientInterface::bulk().
  517    Call to an undefined method nodespark\DESConnector\ClientInterface::bulk().
  532    Parameter $search of method Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::getAutocompleteSuggestions() has
         invalid typehint type Drupal\search_api_autocomplete\SearchInterface.
  545    Method Drupal\search_api\Query\QueryInterface::postExecute() invoked with 1 parameter, 0 required.
  549    Instantiated class Drupal\search_api_autocomplete\Suggestion\SuggestionFactory not found.
  556    Call to method createFromSuggestionSuffix() on an unknown class Drupal\search_api_autocomplete\Suggestion\SuggestionFactory.
  656    Class nodespark\DESConnector\Elasticsearch\Aggregations\Metrics\Stats constructor invoked with 2 parameters, 3 required.
  789    Binary operation "*" between 86400 and string results in an error.
  813    Call to an undefined method Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::getIndexFields().
  826    Function search_api_extract_inner_type not found.
  864    Offset 'facet_type' does not exist on string.
  864    Offset 'field' does not exist on string.
  875    Offset 'facet_type' does not exist on string.
  876    Offset 'facet_type' does not exist on string.
  891    Call to an undefined method Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::getIndexFields().
  893    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use
         mb_strtolower() instead.
  894    Call to an undefined method Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::parseConditionGroup().
  901    Call to an undefined method Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::parseConditionGroup().
  943    Call to an undefined method Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::getOption().
  957    Function facetapi_get_active_searchers not found.
  960    Function facetapi_adapter_load not found.
  997    PHPDoc tag @param has invalid value ($adapter): Unexpected token "$adapter", expected type at offset 62
  997    PHPDoc tag @param has invalid value ($facet_id): Unexpected token "$facet_id", expected type at offset 83
  1039   Call to an undefined method Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::getIndexFields().
  1048   Function search_api_extract_inner_type not found.
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Behat/features/bootstrap/ElasticsearchConnectorFeatureContext.php
 ------ ----------------------------------------------------------------------------------------------------------------------------------------
         Class ElasticsearchConnectorFeatureContext was not found while trying to analyse it - autoloading is probably not configured properly.
 ------ ----------------------------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Kernel/ElasticsearchTest.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------
         Class Drupal\elasticsearch_connector\Tests\Kernel\ElasticsearchTest was not found while trying to analyse it - autoloading is probably not configured
         properly.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------
  Line   tests/src/Unit/ClusterManagerTest.php
 ------ -------------------------------------------------------------------------------
  51     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::get().
  53     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::set().
  80     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::loadMultiple().
  87     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getStorage().
 ------ -------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------
  Line   tests/src/Unit/ElasticSearch/ClientManagerTest.php
 ------ ----------------------------------------------------------------------------
  35     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::create().
  53     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getRawUrl().
 ------ ----------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------
  Line   tests/src/Unit/ElasticSearch/Parameters/Builder/SearchBuilderTest.php
 ------ ---------------------------------------------------------------------------
  32     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getIndex().
 ------ ---------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------
  Line   tests/src/Unit/ElasticSearch/Parameters/Factory/FilterFactoryTest.php
 ------ --------------------------------------------------------------------------------------
  28     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  31     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  34     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  50     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  53     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  56     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  73     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  76     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  79     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  82     Call to deprecated method setExpectedException() of class Drupal\Tests\UnitTestCase:
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Backward compatibility for PHPUnit 4 will no longer be supported.
  94     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  97     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  100    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  114    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  117    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  120    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  134    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  137    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  140    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  156    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  159    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  162    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  181    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  184    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  187    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  206    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  209    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  212    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  231    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  234    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  237    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  257    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getValue().
  260    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getOperator().
  263    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getField().
  266    Call to deprecated method setExpectedException() of class Drupal\Tests\UnitTestCase:
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Backward compatibility for PHPUnit 4 will no longer be supported.
 ------ --------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------
  Line   tests/src/Unit/ElasticSearch/Parameters/Factory/MappingFactoryTest.php
 ------ --------------------------------------------------------------------------------------
  21     Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  22     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  24     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getBoost().
  40     Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  41     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  50     Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  51     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  60     Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  61     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  70     Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  71     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  80     Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  81     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  91     Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  92     Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  101    Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  102    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
  111    Variable $field_prophecy in PHPDoc tag @var does not match assigned variable $field.
  112    Call to an undefined method Prophecy\Prophecy\ObjectProphecy::getType().
 ------ --------------------------------------------------------------------------------------


 [ERROR] Found 248 errors

Comment	File	Size	Author
#21	interdiff_18-21.txt	65.86 KB	timotej-pl
#21	3110970-21.patch	65.09 KB	timotej-pl
#21
#20	interdiff_17-18.txt	1.72 KB	r.spring
#18	elasticsearch-connector-9.0.x.patch	10.56 KB	r.spring
#18
#17	elasticsearch_view_Tested.png	73.46 KB	shaktik
#17	elasticsearch_index_d9_0_5_dev_index.png	111.48 KB	shaktik
#17	es_d8-and-d9.png	30.6 KB	shaktik
#17	interdiff_15-17.txt	3.1 KB	shaktik
#17	3110970-17.patch	12.91 KB	shaktik
#17
#15	d9-compatibility-3110970-15.patch	10.87 KB	kmbremner
#15
#14	d9-compatibility-3110970-14.patch	2.79 KB	drewfranz
#14
#7	d9-compatibility-3110970-7.patch	1.51 KB	imalabya
#7
#6	3110970-drupal9-readiness.patch	517 bytes	bonfil1
#6
#4	3110970-4.patch	10.91 KB	kbrodej
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 February 2020 at 09:14

kbrodej created an issue. See original summary.

Comment #2

bcizej CreditAttribution: bcizej at Agiledrop - Your Trusted Drupal Teammates commented 4 February 2020 at 09:18

Issue summary:

View changes

Comment #3

kbrodej CreditAttribution: kbrodej at Agiledrop - Your Trusted Drupal Teammates commented 4 February 2020 at 09:21

Issue summary:

View changes

File	Size
3110970-4.patch	10.91 KB

Comment #5

abhijeet.kumar2107 CreditAttribution: abhijeet.kumar2107 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented 10 May 2020 at 21:00

Assigned:

Unassigned

» abhijeet.kumar2107

Comment #6

bonfil1 CreditAttribution: bonfil1 as a volunteer commented 28 May 2020 at 14:19

File	Size
3110970-drupal9-readiness.patch	517 bytes

Adding a core_version_requirement entry to the info.yml

Comment #7

imalabya

he/him

English

Bangalore

CreditAttribution: imalabya at Specbee commented 4 June 2020 at 02:05

Status:

Needs work

» Needs review

File	Size
d9-compatibility-3110970-7.patch	1.51 KB

Added patch to make the module D9 compatible.

Comment #8

imalabya

he/him

English

Bangalore

CreditAttribution: imalabya at Specbee commented 4 June 2020 at 02:06

Assigned:

abhijeet.kumar2107

» Unassigned

Comment #9

rferguson CreditAttribution: rferguson commented 15 June 2020 at 12:46

Will there be an officially supported D9 version released soon?

Comment #10

skek CreditAttribution: skek commented 16 June 2020 at 13:16

Hi @rferguson,

I'm planning to work soon on this one till the end of the month.
Keep you posted here.

Comment #11

FiNeX CreditAttribution: FiNeX as a volunteer commented 1 July 2020 at 08:51

Hi, I'm also interested on the D9 version. Thank you! :-)

Comment #12

ptt-homme CreditAttribution: ptt-homme commented 2 July 2020 at 15:31

Hi @skek,

Any chance to help you on this?

Let me know. Ptt-homme.

Comment #13

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 2 July 2020 at 16:53

Title:	Durpal 9 Code deprecation	» Remove the code deprecated in Drupal 9
Category:	Support request	» Task

Comment #14

drewfranz CreditAttribution: drewfranz at Pac-12 Networks commented 27 July 2020 at 19:31

File	Size
d9-compatibility-3110970-14.patch	2.79 KB

Adding patch to fix additional deprecated code.

Comment #15

kmbremner

he/him

English

Wetherby, UK

CreditAttribution: kmbremner as a volunteer commented 5 August 2020 at 11:45

File	Size
d9-compatibility-3110970-15.patch	10.87 KB

Combine patches #7 and #14.
Also, add further deprecation fixes.

Comment #16

fgm

French

Paris, France

CreditAttribution: fgm as a volunteer and at OSInet commented 16 August 2020 at 14:25

Status:

Needs review

» Needs work

Just for the record, all these undefined functions belong to the D7 version. I suspect the functions calling them are actually (or most of them) no longer useful and can just be removed instead of porting them to the equivalent D9 API.

In addition, even the patch in #15 still contains such undefined D7 calls.

Comment #17

shaktik

he/him

Hindi

New Delhi

CreditAttribution: shaktik as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented 15 September 2020 at 12:50

Status:

Needs work

» Needs review

File	Size
3110970-17.patch	12.91 KB

interdiff_15-17.txt	3.1 KB
es_d8-and-d9.png	30.6 KB
elasticsearch_index_d9_0_5_dev_index.png	111.48 KB
elasticsearch_view_Tested.png	73.46 KB

Can we skip the analysis part on this ticket?

bash-3.2# ./vendor/bin/drupal-check -d  modules/elasticsearch_connector/
 60/60 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -----------------------------------------------------------------------------
  Line   tests/src/Behat/features/bootstrap/ElasticsearchConnectorFeatureContext.php
 ------ -----------------------------------------------------------------------------
         Reflection error: Drupal\DrupalExtension\Context\RawDrupalContext not
         found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ -----------------------------------------------------------------------------

 [ERROR] Found 1 error

I have check and fixed deprecation issues, working fine on D8 as well D9 on my local tested, kindly check.

Thanks,
Shakti

Comment #18

r.spring CreditAttribution: r.spring commented 18 September 2020 at 06:44

File	Size
elasticsearch-connector-9.0.x.patch	10.56 KB

After applying #17 on Drupal 9.0.6 I was getting an error while trying to add a Search API index.
I had to remove all instances of

-use Symfony\Component\EventDispatcher\Event;
+use Symfony\Contracts\EventDispatcher\Event;

as a workaround to get patch #17 working.

This is because Drupal 9.0.x still uses the deprecated Event class - see https://www.drupal.org/node/3159012

Attached is #17 without the Event class namespace changes. Note that this is a workaround to support 9.0.x only, not all future versions.

Comment #19

shaktik

he/him

Hindi

New Delhi

CreditAttribution: shaktik as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented 18 September 2020 at 14:51

Hi @r.spring,

Could you share interdiff.

Comment #20

r.spring CreditAttribution: r.spring commented 21 September 2020 at 04:45

File	Size
interdiff_17-18.txt	1.72 KB

Ah yes--attached.

Comment #21

timotej-pl CreditAttribution: timotej-pl at Agiledrop - Your Trusted Drupal Teammates commented 24 September 2020 at 11:55

File	Size
3110970-21.patch	65.09 KB

interdiff_18-21.txt	65.86 KB

Reviewed patch #18 and fixed some annotation errors.

Comment #22

rferguson CreditAttribution: rferguson commented 7 October 2020 at 19:41

Will there be an officially supported D9 version released soon with these patches rolled in?

Comment #23

8 October 2020 at 22:03

skek committed 7117ae7 on 8.x-7.x authored by timotej-pl

Issue #3110970 by shaktik, r.spring, timotej-pl, kbrodej, imalabya,...

Comment #24

skek CreditAttribution: skek commented 8 October 2020 at 22:12

Status:

Needs review

» Fixed

Comment #25

22 October 2020 at 22:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Remove the code deprecated in Drupal 9

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Referenced by

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community