Drupal 9 readiness

CommentFileSizeAuthor
#3 3111330-3.patch384 bytespratik_kamble
#2 drupal9_compatibility-3111330-2.patch1.07 KBrksyravi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rksyravi created an issue. See original summary.

rksyravi’s picture

rksyravi
Primary language Hindi
Location New Delhi, 🇮🇳
CreditAttribution: rksyravi as a volunteer and at Srijan | A Material+ Company for Srijan | A Material+ Company commented
Issue summary: View changes
Status: Active » Needs review
FileSize
drupal9_compatibility-3111330-2.patch1.07 KB

Apply this patch after https://www.drupal.org/project/instagram_formatter/issues/3111321
Uses:
* Download the patch to the module folder.
* Run git apply -v < drupal9_compatibility-3111330-2.patch
* Run git add command
* Run git commit -m 'Issue #3111330 by rksyravi: Drupal 9 Readiness'--author="rksyravi <rksyravi@3402584.no-reply.drupal.org>"

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 for Drupal India Association commented
FileSize
3111330-3.patch384 bytes

@rksyravi composer.json file is not needed anymore. Attaching a new patch which removes the composer.json.

rksyravi’s picture

rksyravi
Primary language Hindi
Location New Delhi, 🇮🇳
CreditAttribution: rksyravi as a volunteer and at Srijan | A Material+ Company for Srijan | A Material+ Company commented

Hi @pratik_kamble,
composer.json is required for Drupal 9 compatibility, otherwise it will fail in the automated testing.
Please check and make the changes accordingly.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 for Drupal India Association commented

@rksyravi can you provide the documentation if you have any. As per my knowledge, having composer.json is not needed anymore.

rksyravi’s picture

rksyravi
Primary language Hindi
Location New Delhi, 🇮🇳
CreditAttribution: rksyravi as a volunteer and at Srijan | A Material+ Company for Srijan | A Material+ Company commented

Hi @pratik_kamble,

Please do the automated testing with Drupal 9 dev, you'll get to know.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 for Drupal India Association commented

If you go through https://www.drupal.org/node/3070687 you will realize the composer.json is no longer needed.

rksyravi’s picture

rksyravi
Primary language Hindi
Location New Delhi, 🇮🇳
CreditAttribution: rksyravi as a volunteer and at Srijan | A Material+ Company for Srijan | A Material+ Company commented

Hi @pratik_kamble,

From Jan 9 2020, composer.json is not necessary for the drupal-core version requirement, we can add the version to either .info.yml or composer.json file.
But still, we can use both.

firass.ziedan’s picture

firass.ziedan
Location Jordan
CreditAttribution: firass.ziedan at Vardot commented

@rksyravi @pratik_kamble Thanks for helping. committed.

firass.ziedan’s picture

firass.ziedan
Location Jordan
CreditAttribution: firass.ziedan at Vardot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.