#3067821: Fix [Total Control Dashboard] uses of deprecated Drupal core APIs and standard Drupal Practice

drupal-check docroot/modules/contrib/total_control

14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors


Upgrade status


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Total Control 8.x-2.0-beta2
Scanned on Thu, 02/13/2020 - 15:59.

1 warning found.

#3113217: Drupal 9 Readiness for [Total Control Admin Dashboard] with Drupal
coding standard and practice

modules/contrib/total_control/total_control.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                        MESSAGE                         │
├──────────┼──────┼────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to │
│ manually │      │ total_control.info.yml to designate that the module is │
│          │      │ compatible with Drupal 9. See                          │
│          │      │ https://www.drupal.org/node/3070687.                   │
│          │      │                                                        │
└──────────┴──────┴────────────────────────────────────────────────────────┘




Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Total Control Admin Dashboard Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,info,txt,md /var/www/html/products/total_control/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,info,txt,md /var/www/html/products/total_control/

Check Total Control Admin Dashboard Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,info,txt,md /var/www/html/products/total_control/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,info,txt,md /var/www/html/products/total_control/

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RajabNatshah created an issue. See original summary.

Rajab Natshah’s picture

Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes

  • RajabNatshah committed 996a6e7 on 8.x-2.x
    Issue #3113217: Drupal 9 Readiness for [Total Control Admin Dashboard]...
Rajab Natshah’s picture

Assigned: Rajab Natshah » Mohammed J. Razem
Issue summary: View changes
Status: Active » Needs review
FileSize
24.9 KB
rajab@vardot-dev:/var/www/html/products/total_control$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,info,txt,md /var/www/html/products/total_control/

rajab@vardot-dev:/var/www/html/products/total_control$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,info,txt,md /var/www/html/products/total_control/

Minified

FILE: /var/www/html/products/total_control/css/theme/total-control.theme.css
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------

Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Rajab Natshah’s picture

Rajab Natshah’s picture

Issue tags: -varbase-9.0.0 +varbase-9.1.0
Rajab Natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Rajab Natshah’s picture

Rajab Natshah’s picture

Title: Drupal 9 Readiness for [Total Control Admin Dashboard] with Drupal coding standard and practice » Drupal 9 compatibility for [Total Control Admin Dashboard] with Drupal coding standard and practice
Issue tags: -Drupal 9 readiness