There are a few things to fix according to this report:

Call to deprecated function db_select(). Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get a database connection injected into your service from the container and call select() on it.

Call to deprecated function db_insert(). Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get a database connection injected into your service from the container and call insert() on it.

Call to deprecated function db_driver(). Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get a database connection injected into your service from the container and call driver() on it.

Call to deprecated constant COMMENT_ANONYMOUS_MAYNOT_CONTACT: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use Drupal​\​comment​\​CommentInterface::ANONYMOUS_MAYNOT_CONTACT instead.

And when 8.7 is unsupported:

Usage of deprecated trait Drupal​\​Tests​\​taxonomy​\​Functional​\​TaxonomyTestTrait in class [redacted]:9.0.0. Use Drupal​\​Tests​\​taxonomy​\​Traits​\​TaxonomyTestTrait instead.

CommentFileSizeAuthor
#4 3114443-4.patch4.65 KBgnuget
#4 3114443-2-4-interdiff.txt333 bytesgnuget
#2 3114443.patch4.62 KBgnuget
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles created an issue. See original summary.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Active » Needs review
FileSize
3114443.patch4.62 KB

Wow!

The changes were super straightforward. Great!

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 2: 3114443.patch, failed testing. View results

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Needs work » Needs review
FileSize
3114443-2-4-interdiff.txt333 bytes
3114443-4.patch4.65 KB

Interesting... maybe the dependency must be mentioned in the composer.json file... trying again.

  • gnuget authored ba2f514 on 8.x-1.x 
    Issue #3114443 by gnuget, greggles: Drupal 8 deprecation report for...
gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Needs review » Fixed
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented

Wow, thanks gnuget!

I believe this change

+use Drupal\Tests\taxonomy\Traits\TaxonomyTestTrait;

will break for users on 8.7.x. That is probably OK since it's only in a test and people on 8.7.x are unlikely to be running tests, just noting that risk.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented

Ok, I'm going to keep an eye in the issue queue if someone is having problems with the trait I will undo that specific change.

Thanks!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented

Seems like a great plan.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

KlemenDEV’s picture

KlemenDEV CreditAttribution: KlemenDEV as a volunteer and at Pylo commented

Any plans to get the patch merged in a release?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Colorado Governor's Office of Information Technology - Colorado Digital Service commented

@Klemen Pevec did you test out the latest dev to confirm it works well?

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented

I just released the 8.x.1.1 version with these changes.

https://www.drupal.org/project/comment_notify/releases/8.x-1.1