Problem/Motivation

Checking the module for deprecated functions in Drupal 9 Deprecated Code Report found out that there are deprecated tests.

 ------ ------------------------------------------------------------------------------------------------------ 
  Line   src/Tests/FlexsliderTest.php                                                                          
 ------ ------------------------------------------------------------------------------------------------------ 
  14     Class Drupal\flexslider\Tests\FlexsliderTest extends deprecated class Drupal\simpletest\WebTestBase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                            
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                           
  45     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:                             
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                            
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                           
 ------ ------------------------------------------------------------------------------------------------------

They should be converted into PHPUnit tests.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 flexslider-3114922-4.patch14.68 KBandralex
#3 flexslider-3114922-3.patch14.67 KBandralex
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andralex created an issue. See original summary.

andralex’s picture

andralex CreditAttribution: andralex at EPAM Systems for EPAM Systems commented
Assigned: Unassigned » andralex
Issue summary: View changes
andralex’s picture

andralex CreditAttribution: andralex at EPAM Systems for EPAM Systems commented
Assigned: andralex » Unassigned
Status: Active » Needs review
FileSize
flexslider-3114922-3.patch14.67 KB

Here is a proposed patch with converted tests and code style fixes as well.

andralex’s picture

andralex CreditAttribution: andralex at EPAM Systems for EPAM Systems commented
FileSize
flexslider-3114922-4.patch14.68 KB

I have used the wrong assertion by mistake. This should now work.

  • andralex authored 220ce11 on 8.x-2.x 
    Issue #3114922 by andralex: Update Simpletest tests into Unit tests
amaria’s picture

amaria CreditAttribution: amaria as a volunteer commented
Status: Needs review » Fixed

I have reviewed and pushed this to dev, with some minor changes to a few asserts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.