Replace deprecated libraries usage [#3114925]

Problem/Motivation

Checking the module for deprecated functions in Drupal 9 Deprecated Code Report there are some errors related to deprecated library usage.

 ------ ------------------------------------------------------------------ 
  Line   flexslider.install                                                
 ------ ------------------------------------------------------------------ 
  34     Call to deprecated function libraries_detect():                   
         Will be removed before a stable Drupal 8 release. Please use the  
         new library load and managment concepts described at:             
         https://www.drupal.org/node/2170763                               
 ------ ------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   flexslider.module                                                 
 ------ ------------------------------------------------------------------ 
  83     Call to deprecated function libraries_get_path():                 
         Will be removed before a stable Drupal 8 release. Please use the  
         new library load and managment concepts described at:             
         https://www.drupal.org/node/2170763                               
 ------ ------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   src/Form/FlexsliderForm.php                                       
 ------ ------------------------------------------------------------------ 
  513    Call to deprecated function libraries_detect():                   
         Will be removed before a stable Drupal 8 release. Please use the  
         new library load and managment concepts described at:             
         https://www.drupal.org/node/2170763                               
 ------ ------------------------------------------------------------------

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#4	flexslider.libraries.3114925-4.patch	5.36 KB	AdamPS
#4	8.x-2.x: PHP 5.5 & MySQL 5.5, D8.9 Composer error. Unable to continue.
#3	3114925-3.patch	1.31 KB	Suresh Prabhu Parkala
#3	8.x-2.x: PHP 5.5 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7.2 & MySQL 5.5, D8.9 3 pass, 6 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 February 2020 at 17:26

andralex created an issue. See original summary.

Comment #2

andralex CreditAttribution: andralex at EPAM Systems for EPAM Systems commented 20 February 2020 at 17:27

Parent issue:

#3114922: Update Simpletest tests into Unit tests

File	Size
3114925-3.patch	1.31 KB
8.x-2.x: PHP 5.5 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7.2 & MySQL 5.5, D8.9 3 pass, 6 fail

Comment #4

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented 15 April 2020 at 19:03

File	Size
flexslider.libraries.3114925-4.patch	5.36 KB
8.x-2.x: PHP 5.5 & MySQL 5.5, D8.9 Composer error. Unable to continue.

Comment #5

amaria CreditAttribution: amaria as a volunteer commented 20 May 2020 at 17:41

I don't think it's a good idea to just remove the Libraries API without some means of update. I'll work on providing a smooth transition from Libraries API. All contributors will receive proper attribution.

Comment #6

12 June 2020 at 21:30

amaria authored 5936481 on 8.x-2.x

Issue #3114925 by AdamPS, Suresh Prabhu Parkala, amaria: Replace...

Comment #7

amaria CreditAttribution: amaria as a volunteer commented 12 June 2020 at 21:39

Status:

Needs review

» Fixed

This has been updated in the latest dev version. I've added some changes to keep the access to Library API if it is installed. This code will be removed once 8.9 is the minimal supported version of Drupal 8.